-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest respec #3944
Use latest respec #3944
Conversation
I'm not sure I like this change. I'm trying to give it a chance, but the red text made it easier to scan for certain things.
What are the differences? Is it a different package, a different configuration...? |
If the red is too dramatic for folks, we could choose another color? Even a gray that is distinctive enough to clearly stand out? We should run A11Y (accessabilty) metrics on our rendering (no matter what we do with this color). |
Good idea, which tool(s) would you recommend? |
Both respec-rendered variants differ from Github markdown rendering. |
Accessibility Human here :) - here is the tldr; on a11y // and an overly informative answer with more tools and info. I also did a bunch of tests for you. tldr; If you are just using 1 tool - use Google Lighthouse in the Chrome Developer Tools Run a Desktop and a Mobile test | Mode: Navigation | Categories: Just check them all It will give you some great automatic feedback and is good to check before rolling new versions. BackgroundBackground on Accessibility & Testing: Regarding accessibility standards, the primary specifications you should focus on are WCAG (Web Content Accessibility Guidelines) and ARIA (Accessible Rich Internet Applications), both maintained by the W3C (World Wide Web Consortium).
Your Results
Here are your Desktop Results (mobile were similar) Issues:
Issues (with better stats):
I did the top manual tests for the updated site - it scored really well: Keyboard - There are several to test here. I just did them & you are in good shape.
ZOOM/Magnification
Screen Readers
|
I am glad to dig into the accessibility issues further and propose some recommendations to get you up to WCAG 2.1 AA Compliance (this is the current best-practice target to aim for). That seems far, far outside the scope of this issue - but I can start a thread if someone can recommend the best place for it. |
Thank you @stringtheory! We would definitely like to improve our accessibility game, and you have already helped us with these pointers :) Could you create a new issue for anything we are missing (in this same repo), please? Even if we don't get all of it sorted out before this round of patches, we will keep iterating. |
Created issue #3946 to tackle this. @stringtheory Please feel free to comment and add more recommendations. |
Feedback:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editor configuration was removed out of the changes 👍
Fixes #3845
Fixes #3852
As discussed in TDC call on 2024-07-04
As discussed in TDC call on 2024-07-11
respec-w3c.js
Differences due to new ReSpec defaults
<h1>
and<h2>
- keepReverted differences
Please compare