-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify data model types and formats #4045
Merged
Merged
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99b0fd8 - Browse repository at this point
Copy the full SHA 99b0fd8View commit details
Commits on Aug 21, 2024
-
Use older JSON spec consistently.
Co-authored-by: Ralf Handl <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c589651 - Browse repository at this point
Copy the full SHA c589651View commit details
Commits on Aug 22, 2024
-
Improve table, make section for formats
We had an anchor present for data type formats, but without a section headering. At this point, there is enough information to have a section heading. Also took @mikekistler's suggestion on flipping the first two table columns, and tried "JSON Data Type" as a compromise between "Data Model Type" and "Instance Type".
Configuration menu - View commit details
-
Copy full SHA for 898949f - Browse repository at this point
Copy the full SHA 898949fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bc4e48 - Browse repository at this point
Copy the full SHA 2bc4e48View commit details -
Co-authored-by: Mike Kistler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4b8378a - Browse repository at this point
Copy the full SHA 4b8378aView commit details -
Use "JSON data types" consistently where relevant.
Co-authored-by: Mike Kistler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1c8f451 - Browse repository at this point
Copy the full SHA 1c8f451View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0b94cf5 - Browse repository at this point
Copy the full SHA 0b94cf5View commit details
Commits on Aug 26, 2024
-
Clarifications from mikekistler on OAS data type vs JSON schema kwd/f…
…mt restrictions Clarifies that OAS data modeling is based on the types in the `type` validation keyword, but JSON Schema keywords and formats apply (or not) based on the JSON instance data model, which does not include integers. Co-authored-by: Mike Kistler <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 151f316 - Browse repository at this point
Copy the full SHA 151f316View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8f626a5 - Browse repository at this point
Copy the full SHA 8f626a5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.