-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] account_financial_report: Open items groupy by salesman #1203
[16.0][IMP] account_financial_report: Open items groupy by salesman #1203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review. LGTM
It's functionally working fine, but IMO the translations should have been done using Weblate. |
Let's merge it for not having any conflict: /ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 0ff95b6. Thanks a lot for contributing to OCA. ❤️ |
Hello, please see OCA/l10n-italy#4285 Isn't there any OCA policy about avoiding possible breaking changes? Thanks |
Well, these kind of side effects are barely difficult to pre-detect on repos outside here. We can propose the patch though. @carolinafernandez-tecnativa can you please? |
@pedrobaeza @carolinafernandez-tecnativa PR already open at OCA/l10n-italy#4286 thanks I was wondering if any safeguard policy can be applied. |
Yeah, that can be a solution indeed. We'll take it into account for the next time. |
Fw-port #1175
TT49193
@Tecnativa
@pedrobaeza @victoralmau