Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] account_payment_purchase: changing many2one resets payment_mode #899

Closed
ae-landoo opened this issue Feb 24, 2022 · 2 comments · Fixed by #900
Closed

[14.0] account_payment_purchase: changing many2one resets payment_mode #899

ae-landoo opened this issue Feb 24, 2022 · 2 comments · Fixed by #900
Labels

Comments

@ae-landoo
Copy link

Hi,
We've seen that when the field purchase_vendor_bill_id is changed and a purchase is selected from it, the payment_mode_id is always reseted because it is using the reference purchase_id.
new_mode = self.purchase_id.payment_mode_id.id or False
We've made this change, and it seems to work as it should.
new_mode = self.purchase_vendor_bill_id.purchase_order_id.payment_mode_id.id or False
The same goes for the partner_bank_id field.
@MiquelRForgeFlow

@ae-landoo ae-landoo added the bug label Feb 24, 2022
@Mat-moran
Copy link

We have test your solution and it works OK. We are going to propose PR, if you prefer to do it yourself just remove ours.
Thanks @ae-landoo

@ae-landoo
Copy link
Author

Just do it by yourself, it is ok for us.
Best regards @Mat-moran

cramosh added a commit to dm-integrations/bank-payment that referenced this issue Apr 12, 2022
airlessproject pushed a commit to airlessproject/bank-payment that referenced this issue May 20, 2022
airlessproject pushed a commit to airlessproject/bank-payment that referenced this issue May 20, 2022
aisopuro pushed a commit to avoinsystems/bank-payment that referenced this issue Aug 16, 2022
ramiadavid pushed a commit to ramiadavid/bank-payment that referenced this issue Dec 20, 2022
ramiadavid pushed a commit to ramiadavid/bank-payment that referenced this issue Mar 24, 2023
ramiadavid pushed a commit to ramiadavid/bank-payment that referenced this issue Jun 1, 2023
agyamuta pushed a commit to ursais/bank-payment that referenced this issue Sep 11, 2023
ramiadavid pushed a commit to ramiadavid/bank-payment that referenced this issue Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants