[16.0][MIG] cooperator: migration to 16.0 #86

Signed-off-by: Carmen Bianca Bakker <[email protected]>

- remove coop_candidates from cooperators kanban view - keep only coop_candidates in coop_candidates view - remove legal reprentative in both

Signed-off-by: Carmen Bianca Bakker <[email protected]>

- refactor the form using templates - simplify the design: - replace tables by bootstrap columns - use columns for the overall form rather than for individual fields - use HTML5 widgets for the Part Numbers - use adequate bootstrap classes - use HTML5 date widget

fix incorrect call to ._get_share_transfer_mail_template() that was forgotten during the recent correction of "transfert" to "transfer".

* make subscription.request.name a stored computed field to allow to search by any part of the full name. * fix subscription request views: use only firstname and lastname.

Previously, if either firstname or lastname was (unexpectedly) empty, an error would be thrown. This commit uses approximately the same code approach as partner-contact/partner_firstname to compute the full name. Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]>

fix error that happens when creating a company contact with a sub-contact.

fix creation of subscription request from partner by adding missing fields: firstname, lastname and lang.

Don't use value from self when looping over a list Signed-off-by: Carmen Bianca Bakker <[email protected]>

- more explicit variable name - test no longer check the id number validity - fix tests

The translation files were not moved since the translated terms were empty. new field default_capital_release_request_payment_term made not company dependent because company dependent fields don't make sense on res.company model.

Company dependent fields don't make sense on res.company. Also removed the required on the company configuration since - it is caught in the code if empty. - contraints on company fields without default cannot be set by odoo on installation.

wip

Signed-off-by: Carmen Bianca Bakker <[email protected]>

+ remove unused templates and css classes

Signed-off-by: Carmen Bianca Bakker <[email protected]>

email_template_config adds a field `force_email_send` to mail templates. This field is referenced nowhere in the cooperator code. Signed-off-by: Carmen Bianca Bakker <[email protected]>

There is actually no difference between fr and fr_be.

cooperator.view_res_partner_filter view references the supplier field, which is defined in account.res_partner_view_search and not in base.view_res_partner_filter.

allow to generate capital release request reports from the print menu.

If we don't do this, Odoo will complain that we should be using selection_add. Signed-off-by: Carmen Bianca Bakker <[email protected]>

fix company reference in cooperator certificate report.

* remove newline characters in subjects; newline characters in subjects causes an error which prevents messages from being sent. * remove a period at the end of a subject. * replace "certificat" by "certificate" in report names.

fix capital release request report attachment names: base the value on the default invoice attachment names, which results in the same value for the 3 file types (unless the name is not set or the state is not "posted"): internal account.move attachment, email attachment and print report file name.

* improve french translation (by checking the differences between the old fr and fr_be translations). * add fr_be translation for specific belgian terms only.

move jquery.inputmask.bundle.js from cooperator to cooperator_website, where it is used.

remove the html description file of all modules, as they are outdated, they are not automatically updated by the ocabot, they add redundancy with the readme.rst file, which is used as a fallback (to display the module description in odoo) and works just fine.

fix multiple glitches related to subscription requests: * fix subscription request state when creating one from a partner. * fix partner matching by email or company register number. * fix subscription request name for companies. * refactor .create() method to handle both people and companies. * add several tests. * fix email templates for companies. * update cooperator.pot, fr and fr_be translations: the only change is the way to access the first name from the email templates; the reason that this results in quite some changes in the files is that this change causes the strings to be ordered differently.

Put the representative type in cooperator module instead of in partner_contact_address for inclusion in OCA.

add deprecation warning to subscription.request.create_comp_sub_req().

fix author and website manifest properties to follow oca's guidelines.

Set up account test data in python rather than relying on module data. accounting data needs to be created even if created in module data because when launching tests, accounting data will be deleted when odoo loads a test chart of account. cf load_for_current_company in chart_template.py in account module Also remove manual creation of the chart of account and remy on the test one. Setup is made in a mixin than can be imported in other cooperator modules. [REF] cooperator: use @users in tests [IMP] cooperator: use datetime.date

Use partner_no_unique_bank instead coopiteasy/addons#226

use a different dummy test iban number than the one used in the demo data to avoid tests failing because of the unique bank account number constraint.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: cooperative-14.0/cooperative-14.0-cooperator Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-cooperator/

move methods from test suite to test mixin to make them available for other modules.

fix effective date of cooperator when the invoice is paid without an account.payment.

Selection widget limits the values to 128 items and has no search function.

ensure _REQUIRED is not modified, otherwise it is a global variable, and it causes these problems: * in a multi-database setup, the required fields can include additional fields because of the configuration of other databases. * values are added to the list continuously, which causes a memory leak.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: cooperative-14.0/cooperative-14.0-cooperator Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-cooperator/

In this commit, the confirmation e-mail template (chosen at random) is configured on the res.company model instead of fetched via its XMLID. In a future commit, all the other cooperator-related e-mail templates will be configured in the same way, using the common scaffolding from this commit. The commit introduces a bug/regression, which is that the confirmation e-mail won't actually be sent. This is a result of the new scaffolding. Before, this happened: 1. cooperator is marked installed. 2. The mail template data file gets sourced, creating the confirmation template's record. 3. The subscription request demo data file gets sourced, creating a subscription.request record. 4. While creating the record, an e-mail using the confirmation template gets sent. In the new logic, this happens: 1. cooperator is marked installed. 2. The mail template data file gets sourced, creating the confirmation template's record, but NOT setting it on company 1. 3. The subscription request demo data file gets sourced, creating a subscription.request record. 4. While creating the record, Odoo tries to send a mail of the template company_id.cooperator_confirmation_mail_template, but the field is empty. 5. Error, obviously, but we've commented out the erroneous code, so let's proceed. 6. As a post-init hook, a copy of the confirmation template gets set on all companies' cooperator_confirmation_mail_template field. We'll need to re-jig the logic to circumvent the error. A problem for future me. Or you, if you're reading this in the distant future. Hello. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…pany Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…n company Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…company Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…are created Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

… otherwise specified This is a big revert of previous commits. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…te sequences on company Signed-off-by: Carmen Bianca BAKKER <[email protected]>

use xml data instead of post-init hook to initialize company data.

add explicit _check_company_auto on account.move even though it is already set on the parent model, because explicit is better than implicit and re-setting it here does no harm.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

refactor subscription.request.validate_subscription_request() by moving parts to new methods.

* move cooperative membership properties from res.partner to new cooperative.membership model. * add company-dependent computed fields on res.partner for backward compatibility.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Previously, these functions were only called on one record. The new configuration correctly searches all records. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: cooperative-14.0/cooperative-14.0-cooperator Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-cooperator/

Currently translated at 18.6% (78 of 418 strings) Translation: cooperative-14.0/cooperative-14.0-cooperator Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-cooperator/it/

Currently translated at 42.5% (178 of 418 strings) Translation: cooperative-14.0/cooperative-14.0-cooperator Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-cooperator/it/

Currently translated at 100.0% (418 of 418 strings) Translation: cooperative-14.0/cooperative-14.0-cooperator Translate-URL: https://translation.odoo-community.org/projects/cooperative-14-0/cooperative-14-0-cooperator/it/

* fix xml declarations. * pad the contents of <odoo> tags with an empty line.

* update email templates to the default odoo layout (what also makes them shorter). * fix the company name in confirmation email template: display the name of the company that made the subscription request instead of the name of the cooperative. * add a description to email templates. * merge the confirmation email template for individuals and companies into one. * update translations.

* refactor subscription.request.create() and use model_create_multi decorator on it and on res.company.create(). * remove subscription.request.create_comp_sub_req() and subscription.request.check_empty_string().

only display shares for the current company on the cooperator certificate.

* fix the layout of all reports by rewriting them from the default invoice layout. * make the capital release request report inherit from the invoice report instead of copying and modifying it. * rename xml ids to improve consistency.

ensure reversals of capital release requests use a name prefix to not clash with normal entries ("RSUBJ" instead of "SUBJ").

fix copyright statements: add missing ones and use the same format everywhere.

fix the display of the first name in email templates and add tests to cover this.

* add operation requests tests. * fix small issues. * remove the useless "subscription" operation request type.

* fix the display of the first name in share transfer email for companies. * improve the code to get the first name in mail templates for companies. * refactor subscription.request.validate_subscription_request().

fix subscription requests created by transfer operations: ensure that no confirmation email is sent, that they don't appear in the list of subscription requests and cannot be erroneously validated.

fix required company fields on subscription request form.

rename internal string value of "blocked" subscription request state from "block" to "blocked".

prevent to create a subscription request where email and company email have the same value, to avoid trying to create a recursive partner hierarchy when validating the subscription request (the partner being the parent of itself).

* fix error when creating a new contact (res.partner). * rework res.partner form view.

ensure that the company_type value of a subscription request is copied to the legal_form field of the created partner.

* add a new "registers" menu entry and move the "subscription register" menu entry there. * add a new "cooperator register" view (and menu entry) to display the cooperative memberships and allow to print the cooperator register (report that was previously on the partner model). * add a "share type" column to the cooperator register report.

* move the "cooperator candidates" menu entry to the "cooperators" menu. * use default filters instead of domains in contact views. * remove the extra columns in the contacts list view; they can now be found in the cooperator register.

* ensure creating a cooperator for a non-current company works. * ensure per-company sequences are used. * add unique per-company constraint on the cooperator register number.

Functions in CooperatorTestMixin are often used in setUpClass which is a class method. Helper functions need to be decorared to be accessible.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

display an error message instead of failing when trying to create a subscription request from a partner and no default share product is found.

* update roadmap (contents and format). * remove obsolete install fragment. * fix link format in usage fragment.

Commits on Aug 16, 2023

[MIG] cooperator: migration to 15.0

huguesdk committed Aug 16, 2023

Configuration menu

View commit details

Copy full SHA for f84fbf9

Browse repository at this point

Copy the full SHA

f84fbf9 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] cooperator: migration to 16.0 #86

[16.0][MIG] cooperator: migration to 16.0 #86

Commits on Aug 14, 2023

Commits on Aug 15, 2023

Commits on Aug 16, 2023

Commits on Aug 22, 2023

Commits on Aug 23, 2023

Commits on Aug 24, 2023

Commits on Aug 25, 2023

Commits on Aug 28, 2023

Commits on Sep 20, 2023

Commits on Sep 21, 2023

Commits on Sep 27, 2023

Commits on Oct 2, 2023

Commits on Oct 3, 2023

Commits on Oct 4, 2023

Commits on Oct 6, 2023

Commits on Oct 9, 2023

Commits on Oct 13, 2023

Commits on Nov 29, 2023