Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] cooperator: Don't send attachment if no remaining shares #98

Closed
wants to merge 3 commits into from
Closed

[14.0][IMP] cooperator: Don't send attachment if no remaining shares #98

wants to merge 3 commits into from

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Oct 27, 2023 •
edited
Loading

@carmenbianca carmenbianca changed the title [14.0[IMP] cooperator: Don't send attachment if no remaining shares [14.0][IMP] cooperator: Don't send attachment if no remaining shares Oct 27, 2023
carmenbianca
carmenbianca commented Oct 27, 2023
View reviewed changes
cooperator/data/mail_template_data.xml
<p>Hello ${object.subscription_request_ids[0].firstname},</p>
<p>Hello ${object.firstname},</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipient may not have subscription requests.

Because this file is marked noupdate, clients need to fix this locally.

@huguesdk
Copy link
Member

@carmenbianca all fixes and improvements to cooperator are currently done on version 16 (and some will probably be backported to 14). the email templates have been heavily reworked. please create a pull request against the coopiteasy:16.0-mig-cooperator branch.

@carmenbianca carmenbianca mentioned this pull request Oct 30, 2023
Merged
@carmenbianca
Copy link
Member Author

@huguesdk see pr here: coopiteasy#3

@huguesdk
Copy link
Member

closing this as it has been handled as part of #86.

@huguesdk huguesdk closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguesdk huguesdk Awaiting requested review from huguesdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carmenbianca @huguesdk