Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] hr_attendance_validation: Ignoring some leave types #155

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

petrus-v
Copy link
Contributor

we are using hr.leaves to manage allowed remote days but we don't want to remove thoses times in attendance validation

Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm: code review

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
@github-actions github-actions bot closed this Aug 4, 2024
@rafaelbn
Copy link
Member

Hello @OCA/human-resources-maintainers , please could you reopen this PR?

Thank you! 🙏🏼
Regards 😄 ❤️

@rafaelbn
Copy link
Member

Hello @petrus-v ,

I you are the author of this module, you can add your self as maintainter so you can merge your self

Do you know about it?

Regards ✋🏼

@rafaelbn
Copy link
Member

Sorry for noise, @nimarosa could you reopen and merge?

@nimarosa nimarosa reopened this Aug 13, 2024
@nimarosa
Copy link

/ocabot rebase

@rafaelbn lets rebase first so we check the tests passes. Then we can merge.

we are using hr.leaves to manage allowed remote days but we
don't want to remove thoses times in attendance validation
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@nimarosa
Copy link

/ocabot merge minor

@petrus-v @rafaelbn please after merge cherry peak this PR to other versions so we maintain same functionality in all versions.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-155-by-nimarosa-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a681d1d into OCA:14.0 Aug 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 35ea8b8. Thanks a lot for contributing to OCA. ❤️

@petrus-v
Copy link
Contributor Author

Thanks @rafaelbn to make this merge possible !

Yes, sometimes I try to put myself as maintainer but I've never use the ocabot command yet ! I've to read a bit more about it to feel confident to merge stuff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants