Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] hr_expense_petty_cash: group by petty cash holder #194

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[15.0][FIX] hr_expense_petty_cash: group by petty cash holder #194

merged 1 commit into from
Sep 19, 2023

Conversation

ps-tubtim
Copy link
Member

This PR is used to fix errors when grouped by Petty Cash Holder.

Selection_136

@Saran440 Saran440 force-pushed the 15.0-fix-hr_expense_petty_cash-group_by_petty_cash_holder branch from 9eed8cf to 122f5dc Compare September 13, 2023 09:51
Saran440
Saran440 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

TheerayutEncoder
TheerayutEncoder approved these changes Sep 19, 2023
View reviewed changes
Copy link

@TheerayutEncoder TheerayutEncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major change 👍

@Saran440
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-194-by-Saran440-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c6b704d into OCA:15.0 Sep 19, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ac646b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@TheerayutEncoder TheerayutEncoder TheerayutEncoder approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps-tubtim @Saran440 @OCA-git-bot @TheerayutEncoder