Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] hr_expense_advance_clearing: clear advance partial #250

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[16.0][FIX] hr_expense_advance_clearing: clear advance partial #250

merged 1 commit into from
Jul 12, 2024

Conversation

Saran440
Copy link
Member

Step to test:

  1. Create advance 100
  2. Clear advance 150
    Selection_005
  3. When register payment clearing with partial it will change state to done
    Selection_006
    Selection_007

This PR fixed allow partial payment clearing

@OCA-git-bot
Copy link
Contributor

Hi @kittiu,
some modules you are maintaining are being modified, check this out!

hitrosol
hitrosol approved these changes Jul 11, 2024
View reviewed changes
Copy link

@hitrosol hitrosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ps-tubtim
ps-tubtim approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Saran440
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-250-by-Saran440-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit abc9c5b into OCA:16.0 Jul 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1fc68a8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitrosol hitrosol hitrosol approved these changes

@ps-tubtim ps-tubtim ps-tubtim approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Saran440 @OCA-git-bot @hitrosol @ps-tubtim