Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_expense_employee_analytic_default: Migration to 17.0 #270

Merged
merged 3 commits into from
Oct 1, 2024
Merged

[17.0][MIG] hr_expense_employee_analytic_default: Migration to 17.0 #270

merged 3 commits into from
Oct 1, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Sep 27, 2024 •
edited
Loading

Migration to 17.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT50068

chienandalu
chienandalu reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the module should be renamed to something like hr_expense_employee_analytic_distribution?

@victoralmau
Copy link
Member Author

I agree that the current name is not the right one, maybe hr_expense_employee_analytic_distribution_default?

What do you think @pedrobaeza ?

pedrobaeza
pedrobaeza approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to keep the name, as there's no better one.

/ocabot migration hr_expense_employee_analytic_default

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 27, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 27, 2024
Open
7 tasks
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-270-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5bd54fc into OCA:17.0 Oct 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d0415ee. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-hr_expense_employee_analytic_default branch October 3, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu