-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][NEW] l10n_br_crm_cnpj_search: busca de CNPJ através do Lead #3289
Draft
corredato
wants to merge
2
commits into
OCA:16.0
Choose a base branch
from
kmee:feature/cnpj-search-crm-lead
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corredato
changed the title
[16.0] [NEW] l10n_br_crm_cnpj_search: busca de CNPJ através do Lead
[16.0][NEW] l10n_br_crm_cnpj_search: busca de CNPJ através do Lead
Aug 16, 2024
rvalyi
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corredato, tem que ver os testes e inclusive adicionar testes com um mock semelhante ao que foi feito no módulo de busca. No repo precisa de 90% de test coverage. Até bater ter isso é bom botar o PR como rascunho.
mileo
requested changes
Aug 26, 2024
Depends on #3306 |
corredato
force-pushed
the
feature/cnpj-search-crm-lead
branch
from
August 28, 2024 11:26
6a999df
to
ad35598
Compare
corredato
force-pushed
the
feature/cnpj-search-crm-lead
branch
3 times, most recently
from
August 29, 2024 18:55
191eae9
to
b919379
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
from
October 10, 2024 11:41
acc4fda
to
87363be
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
11 times, most recently
from
October 17, 2024 10:47
f1e386b
to
90139da
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
3 times, most recently
from
October 21, 2024 13:05
c173033
to
aa72314
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
3 times, most recently
from
October 22, 2024 12:38
66072a4
to
fcb1899
Compare
Tiago370
force-pushed
the
feature/cnpj-search-crm-lead
branch
from
October 22, 2024 13:15
fcb1899
to
204801e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combinação do l10n_br_cnpj_search e l10n_br_crm havia uma ponta solta: Caso necessário, não era possível realizar uma busca das informações de uma empresa através do CNPJ em um lead que não tinha partner_id preenchido, esse módulo faz com que esse problema não exista mais, além de fazer com que informações como CNAE primário, CNAE secundário, capital e natureza legal sejam passadas para o cadastro do parceiro quando um novo contato é criado a partir da conversão de Lead para Oportunidade.
@mileo @antoniospneto @rvalyi