Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] l10n_ch_mis_reports: add new module #429

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

mpanarin
Copy link
Contributor

add mis report data for Switzerland localization

@mpanarin mpanarin force-pushed the 11.0-add-l10n_ch_mis_reports branch from 7c51b13 to 95870ed Compare June 15, 2018 13:41
@mpanarin mpanarin force-pushed the 11.0-add-l10n_ch_mis_reports branch 6 times, most recently from 63e4c76 to 2baedea Compare June 15, 2018 15:48
@yvaucher
Copy link
Member

Code is ok but a README.rst is missing.

@fclementic2c
Copy link
Member

fclementic2c commented Jun 21, 2018

Please remove the ' (at the beguining before the formula) on expressions
example on line '-bale[][('account_id.tag_ids', '=', ref('l10n_ch.account_tag_ch_280').id)]

@yvaucher
Copy link
Member

@fclementic2c will do, this char was probably inserted on the export from Odoo

@yvaucher
Copy link
Member

@fclementic2c extra ' removed from xml file.

@fclementic2c
Copy link
Member

Please also remove ' on line description (see printscreen) - This is pure cosmetic. txs

screenshot-localhost-8989-2018 06 21-13-24-33 1

@yvaucher
Copy link
Member

@fclementic2c already done in last commit:
7ee8a6e#diff-00fed281fc62b3a8a85796e6ef8bfa6cL99

@fclementic2c
Copy link
Member

Rest is Ok :)

Good Job !

@yvaucher
Copy link
Member

yvaucher commented Aug 2, 2018

@mpanarin can you do a rebase on top of #432 as this depends on it

'license': 'AGPL-3',
'depends': [
'l10n_ch',
'mis_builder',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dependency on l10n_ch_account_tags

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mpanarin mpanarin force-pushed the 11.0-add-l10n_ch_mis_reports branch from 7ee8a6e to 5fe0860 Compare August 2, 2018 13:55
@mpanarin
Copy link
Contributor Author

mpanarin commented Aug 2, 2018

@yvaucher rebase and updated

@yvaucher
Copy link
Member

yvaucher commented Aug 2, 2018

@mpanarin thanks, waiting for travis before merge

@mpanarin mpanarin force-pushed the 11.0-add-l10n_ch_mis_reports branch from 5fe0860 to 5b5d4d1 Compare August 2, 2018 15:07
@mpanarin mpanarin force-pushed the 11.0-add-l10n_ch_mis_reports branch from 5b5d4d1 to df9ef89 Compare August 2, 2018 15:43
@yvaucher yvaucher merged commit 99f407e into OCA:11.0 Aug 3, 2018
open-net-sarl pushed a commit to open-net-sarl/l10n-switzerland that referenced this pull request Oct 30, 2018
[ADD] l10n_ch_mis_reports: add new module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants