Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New payment slip for v8 #65

Merged
merged 91 commits into from
Jan 21, 2015
Merged

New payment slip for v8 #65

merged 91 commits into from
Jan 21, 2015

Conversation

nbessi
Copy link
Contributor

@nbessi nbessi commented Nov 26, 2014

No description provided.

draw.text((x, y), ref, font=font, fill=self._fill_color)

@api.model
def _draw_amont(self, draw, font, amount, initial_position, company):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/_draw_amont/_draw_amount/

raise
finally:
buff.close()
for stream in streams:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and fixed

@coveralls
Copy link

Coverage Status

Coverage increased (+14.48%) when pulling 7087551 on nbessi:new_payment_slip into c42091b on OCA:8.0.

@guewen
Copy link
Member

guewen commented Dec 3, 2014

The module base_transaction_id should be added as dependency because it is required in order to reconcile the transaction_ref with the new bank statement.

@coveralls
Copy link

Coverage Status

Coverage increased (+14.29%) when pulling 2952bf8 on nbessi:new_payment_slip into c42091b on OCA:8.0.

@guewen
Copy link
Member

guewen commented Dec 4, 2014

Thanks 👍

@@ -227,7 +221,7 @@ def _check_postal_num(self):
'(01-23456-1 or 12345)')
)

@api.constrains('acc_number', 'bank')
@api.constrains('acc_number', 'bank.ccp')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openerp.models: @constrains('acc_number', 'bank.ccp') parameters must be field names

AFAIK @api.constrains() does not support dotted notation, only fields of the current model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen right you are, we have to add a constrains on res.bank

@coveralls
Copy link

Coverage Status

Coverage increased (+14.29%) when pulling 4cada37 on nbessi:new_payment_slip into c42091b on OCA:8.0.

@nbessi
Copy link
Contributor Author

nbessi commented Dec 16, 2014

needs a rebase


after_success:
coveralls
coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

* Pass the id of the credit line to add in the total in the context
* Extends the depends of the computed field otherwise the first value computed
  without the fees is kept in cache
…nto new_payment_slip

Conflicts:
	l10n_ch_base_bank/invoice.py
@guewen
Copy link
Member

guewen commented Dec 22, 2014

Rebased on top of 8.0.
And merged these fixes #75

@coveralls
Copy link

Coverage Status

Coverage increased (+13.47%) when pulling 1f0da7b on nbessi:new_payment_slip into 2af9826 on OCA:8.0.

When we import V11 files, the bvr numbers are not formatted,
we find them using the unformatted number
@coveralls
Copy link

Coverage Status

Coverage increased (+13.5%) when pulling 8e2f4a8 on nbessi:new_payment_slip into 2af9826 on OCA:8.0.

@tafaRU
Copy link
Member

tafaRU commented Jan 16, 2015

@nbessi could you please rebase on 8.0 to include last fixes released on _l10n_ch_dta_?

Thank you in advance.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.38%) when pulling 00e3561 on nbessi:new_payment_slip into 2af9826 on OCA:8.0.

@nbessi
Copy link
Contributor Author

nbessi commented Jan 16, 2015

@TaraFu I will prefer to have a merge and treat new problem as seprated issues.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.38%) when pulling 3c3373e on nbessi:new_payment_slip into 2af9826 on OCA:8.0.

@eLBati
Copy link
Member

eLBati commented Jan 20, 2015

Hello @nbessi , I'm testing l10n_ch_payment_slip with latest odoo 8 code and trying to print a payment slip from invoice, I always get an empty file.
I noticed _draw_payment_slip does not even get executed. Does this happen to you?
Thanks

@nbessi
Copy link
Contributor Author

nbessi commented Jan 20, 2015

@eLBati no I do not encounterd this problem maybe you have a PIL dependency missing or an other report engine that may conflict.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.24%) when pulling a8c3a80 on nbessi:new_payment_slip into 2af9826 on OCA:8.0.

gurneyalex added a commit that referenced this pull request Jan 21, 2015
@gurneyalex gurneyalex merged commit d8830cd into OCA:8.0 Jan 21, 2015
yvaucher pushed a commit to yvaucher/l10n-switzerland that referenced this pull request Nov 14, 2017
vrenaville pushed a commit to camptocamp/l10n-switzerland that referenced this pull request Jun 22, 2018
[FIX] Scenario to correct SALARY [BIZ-1225]
JuMiSanAr pushed a commit to camptocamp/l10n-switzerland that referenced this pull request Sep 21, 2021
BIZ-1322: Fix: Cancel old productions, picking and moves
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants