[14.0][ADD] ebill_postfinance #675
Conversation
| return res | ||
|
|
||
| def get_process_protocol_list(self, archive_data=False): | ||
| # Is this the processing result of an invoice ? |
There was a problem hiding this comment.
Should it translate as a TODO ?
There was a problem hiding this comment.
Questioning the use of this call to the api.
The situation at the moment is, all possible call to the api are implemented, so they can be used and tested.
But they are not all used yet by the module for real.
There is the roadmap file that contains some more information.
| service = self._get_service() | ||
| res = service.get_registration_protocol_list(archive_data) | ||
| for registration_protocol in res or {}: | ||
| self.get_registration_protocol(registration_protocol.CreateDate) |
There was a problem hiding this comment.
the value returned from this function is not used
There was a problem hiding this comment.
This call is related to the contract subscription update through the web service. And not yet implemented, actually when I tested it I could never get any data.
I learn today that the subscription update through the web service is only implemented for b2ebanking or b2c.
| help="Timeout for each HTTP (GET, POST) request in seconds.", | ||
| ) | ||
|
|
||
| def _get_service(self): |
There was a problem hiding this comment.
Does it create a new session each time, can't we reuse a session by storing the current service?
There was a problem hiding this comment.
This is a very good point. And yes I believe there is some improvement to be done on this...
There was a problem hiding this comment.
Maybe decorating the method with @ormcache would work?
|
Previous fixup fixes the number of references included for each invoice line in the xml payload. |
| self.transaction_id = "-".join( | ||
| [ | ||
| fields.Datetime.now().strftime("%y%m%d%H%M%S"), | ||
| self.invoice_id.name.replace("/", "").replace("_", ""), |
There was a problem hiding this comment.
I would use slugify to make sure there's no weird char.
|
@TDu what's the overall state here? |
|
I squashed all previous commit and then the last fixup adds the credit note to be sent to the server. |
TDu
force-pushed
the
ebillpostfinance
branch
2 times, most recently
from
424485b
to
3a18b6f
Compare
|
@TDu so we are good to merge this? |
|
Maybe you could increase the coverage of the tests? Also you can force-push to retrigger the runboat. Is this ready to be merged otherwise? |
TDu
force-pushed
the
ebillpostfinance
branch
3 times, most recently
from
39a2e84
to
d9e5d2c
Compare
Remove the dependency on stock in the `ebill_postfinance` module. And add a new module `ebill_postfinance_stock` that will integrate in the xml invoice informations related to the deliveries. This is for Odoo implementation that sell only services and have no stock to manage. And do not use the `stock` module.
With the introduction of the use of PyPi to find depending modules, this is not needed anymore, as far as I know, in fact Travis runs without errors. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 3564d8f. Thanks a lot for contributing to OCA. ❤️ |
No description provided.