Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_ch_pain_base : Migration to 14.0 #702

Merged
merged 34 commits into from
Dec 1, 2023
Merged

[14.0][MIG] l10n_ch_pain_base : Migration to 14.0 #702

merged 34 commits into from
Dec 1, 2023

Conversation

ecino
Copy link

@ecino ecino commented Jun 5, 2023

Take another attempt to migrate the module, as previous PR are stale. (#668)

@ecino ecino mentioned this pull request Jun 5, 2023
Open
14 tasks
@ecino ecino force-pushed the 14.0-pain-base branch 4 times, most recently from 9ad4c44 to 1803872 Compare June 5, 2023 11:50
@ecino
Copy link
Author

ecino commented Jun 5, 2023

Travis errors are not related the migrated module 🙅

@ecino
Copy link
Author

ecino commented Oct 16, 2023

@OCA/local-switzerland-maintainers @TDu Is there anyone available to review this pull request, or do you know who the current maintainers of the l10n-switzerland repository are? It's concerning to see the repository inactive, and I'd like to help ensure its continued development. I'm willing to contribute and take on a role as a maintainer if that's a possibility. Please let me know how I can assist in reviving this project.

@TDu
Copy link
Member

TDu commented Oct 18, 2023

Not familiar with this module. I just restarted the tests on Travis to see... As the 14 branch is green now.
It is a shame this module never had tests.
The last commit could be squashed into the previous migration commit.

alexis-via and others added 22 commits October 19, 2023 13:11
@alexis-via @ecino
Migrate to a new architecture with 3 modules for PAIN
ffa1683
@alexis-via @ecino
Add a unit-test for payment type 3
cd3b371 
Fix sepa compute method
@pedrobaeza @ecino
[MIG] Make modules uninstallable
490b834
@pedrobaeza @ecino
[MIG] Rename manifest files
d0aa3f2
@leemannd @ecino
[MIG] l10n_ch_pain_base: Migrated to 10.0
592ed1a
@yvaucher @ecino
Adapt tests to editable ccp on partner bank form
26349cc
@yvaucher @ecino
Fix pain base following change of method signature
dcb303a 
in OCA/bank-payment#366
@ecino
[MIG] l10n_ch_pain_base: Migrate to odoo 11
93591dd
@jcoux @ecino
[11.0][FIX] l10n_ch_pain_base - Fix migration script
513b1a9
@lfr-opennet @ecino
[11.0][FIX] l10n_ch_pain_base - fix error message (OCA#425)
b17b9b4 
* [11.0][FIX] l10n_ch_pain_base - fix error message

Fix of the field used on the UsserError message when no CCP account is set.
The field 'partner_bank.name' doesn't exist, the corresponding field is 'partner_bank.acc_number'
@oca-travis @ecino
[UPD] Update l10n_ch_pain_base.pot
25c3b3c
@OCA-git-bot @ecino
[MIG] Make modules uninstallable
19f1634
@asaunier @ecino
[MIG] l10n_ch_pain_base: Migration to odoo 12
7d18f16
@OCA-git-bot @ecino
[ADD] icon.png
b2f3cae
@oca-travis @ecino
[UPD] Update l10n_ch_pain_base.pot
041db37
@oca-transbot @ecino
Update translation files
837126f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-switzerland-12.0/l10n-switzerland-12.0-l10n_ch_pain_base
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-12-0/l10n-switzerland-12-0-l10n_ch_pain_base/
@OCA-git-bot @ecino
[UPD] README.rst
125c139
@p-tombez @ecino
[11.0] l10n_ch_pain_base: Override address block for Swiss specs
c32cd27
@p-tombez @ecino
[11.0] l10n_ch_pain_base: Fix empty address block generation
6c0909e
@yvaucher @ecino
Pain.001 use l10n_ch_postal field
9ef6138 
Plus drop the need of ISR reference type on invoice
@oca-travis @ecino
[UPD] Update l10n_ch_pain_base.pot
0c91410
@oca-transbot @ecino
Update translation files
b62c009 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-switzerland-12.0/l10n-switzerland-12.0-l10n_ch_pain_base
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-12-0/l10n-switzerland-12-0-l10n_ch_pain_base/
oca-transbot and others added 11 commits October 19, 2023 13:11
@oca-transbot @ecino
Update translation files
a6fe2c1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-switzerland-12.0/l10n-switzerland-12.0-l10n_ch_pain_base
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-12-0/l10n-switzerland-12-0-l10n_ch_pain_base/
@davidwul @ecino
# This is a combination of 4 commits.
5abd66c 
# This is the 1st commit message:

85a93e8

# This is the commit message #2:

use qr_iban validation methode

# This is the commit message #3:

fix commit

# This is the commit message #4:

remove debug info
@davidwul @ecino
Add the ability to include a QR invoice with QRR on a payement order and
0c458f2 
produce a pain001 expected (according to SIX
implementation-guidelines-ct)
@oca-travis @ecino
[UPD] Update l10n_ch_pain_base.pot
ae49b45
@OCA-git-bot @ecino
l10n_ch_pain_base 12.0.2.1.0
1089cae
@oca-transbot @ecino
Update translation files
82c1123 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-switzerland-12.0/l10n-switzerland-12.0-l10n_ch_pain_base
Translate-URL: https://translation.odoo-community.org/projects/l10n-switzerland-12-0/l10n-switzerland-12-0-l10n_ch_pain_base/
@i-vyshnevska @ecino
[12.0][FIX] check if bank attached to not raise sigleton error
66b8f2a
@OCA-git-bot @ecino
l10n_ch_pain_base 12.0.2.1.1
e2e8cbd
@ecino
[IMP] l10n_ch_pain_base: black, isort, prettier
7c7d6f0
@ecino
[MIG] l10n_ch_pain_base: Migration to 13.0
0fab4b8
@ecino
[IMP] l10n_ch_pain_base: black, isort, prettier
598b6d9
@ecino
Copy link
Author

ecino commented Oct 19, 2023

Squashed the commits as requested.

@ecino
Copy link
Author

ecino commented Oct 30, 2023

@TDu Please let me know how we can move forward with this. Many other modules depend on it and we could greatly extend the functionalities of the swiss-localization repository if we take some time to review the pending pull requests.

@ecino
Copy link
Author

ecino commented Nov 30, 2023

@TDu This module is not useful on its own, it's more a technical basis for the two sub-modules, so it's hard to make tests for it, especially because it doesn't add the pain flavors in the payment methods. Do you think we should move this out of the submodules in order to make this module testable, or what would be the approach?

@alexis-via @leemannd Can you review please?

@TDu
Copy link
Member

TDu commented Dec 1, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@TDu The rebase process failed, because command git push --force CompassionCH tmp-pr-702:14.0-pain-base failed with output:

remote: Permission to CompassionCH/l10n-switzerland.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/CompassionCH/l10n-switzerland/': The requested URL returned error: 403

@TDu
Copy link
Member

TDu commented Dec 1, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-702-by-TDu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b7c5e7e into OCA:14.0 Dec 1, 2023
2 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7d11f55. Thanks a lot for contributing to OCA. ❤️

@ecino ecino deleted the 14.0-pain-base branch December 4, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.