-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] l10n_ch_mis_reports: Migration to 16.0 #709
Conversation
xml id replace (same as version 11)
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no experience with this module in the previous versions, but it looks good to me (only code review). One quetion, shouldn't we put the XML files in English and provide translations instead of directly entering records in French?
Thanks for your review ! Yes it would be better but I don't know the english translation. As this is specific for switzerland I guess it's not a big deal if we put it in french, people can then translate it with weblate if needed. |
<field | ||
name="expression" | ||
>-balp[('code', '>=', '3'),('code', '<', '39')][]</field> | ||
<field name="style_id" ref="style_details" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
Could you juste change the style here with
<field name="style_id" ref="style_details" /> | |
<field name="style_id" ref="style_header" /> |
Otherwise it's all ok for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review. Indeed it's nicer with the header style.
928aae9
to
dd34f2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me
@ecino could you merge it? Thanks |
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 1600fc0. Thanks a lot for contributing to OCA. ❤️ |
Migration with following refactor
reviews/opinions are welcome :)