Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oca-create-branch: carry over answers from previous branches #541

Closed
wants to merge 3 commits into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 3, 2022

Carry over the repo name and repo description from previous branch.

@sbidoul sbidoul force-pushed the improve-create-branch branch 3 times, most recently from c3ec189 to cdb9a3f Compare October 3, 2022 19:59
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just a question

def main(new_branch, copier_template, copier_template_vcs_ref, repos):
@click.option(
"--prev-branch",
help="Previous branch where to read some copier answers.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default True?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually a branch name.

Copier is required for oca-create-branch only, and
copier 9 does not support python<3.8.
@simahawk
Copy link
Contributor

@sbidoul in the repo-maintainer tool will already preserve the repo name and description. Hence, I don't think we need this anymore.
See https://github.com/OCA/repo-maintainer/blob/master/oca_repo_maintainer/tools/manager.py#L191

Am I wrong?

Then we might implement a way to keep other keys but it can be done later.

@sbidoul
Copy link
Member Author

sbidoul commented Sep 13, 2024

I think with repo_description I wanted to preserve the body of the repo README.md. But in practice very few repo have it in a copier answer.

So happy to drop oca-create-branch from here and use repo-maintainer-conf for that.

Thanks for that work!

@sbidoul
Copy link
Member Author

sbidoul commented Sep 13, 2024

I keep this open for a while and if we are happy with the new solution, I'll remove create_branch.py from this repo.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 20, 2024

Closing since this is now handled by github.com/oca/repo-maintainer-conf

@sbidoul sbidoul closed this Oct 20, 2024
@sbidoul sbidoul deleted the improve-create-branch branch October 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants