Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] oca-gen-addon-readme: stop emitting an XML declaration #596

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

nilshamerlinck
Copy link
Contributor

@nilshamerlinck nilshamerlinck changed the title gen-addon-readme: stop emitting an XML declaration [IMP] oca-gen-addon-readme: stop emitting an XML declaration Dec 8, 2023
@pedrobaeza
Copy link
Member

But this should be only for 17.0, not the rest of the versions.

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, dunno if it is a blocker to do this for all versions

@nilshamerlinck
Copy link
Contributor Author

Hello guys :)

@sbidoul sbidoul merged commit 9a17033 into OCA:master Dec 10, 2023
6 checks passed
@sbidoul
Copy link
Member

sbidoul commented Dec 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants