Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] mis_builder_budget: allow to specify a company on budget by kpi #630

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[IMP] mis_builder_budget: allow to specify a company on budget by kpi #630

wants to merge 1 commit into from

Conversation

AnizR
Copy link
Contributor

@AnizR AnizR commented Aug 28, 2024

Fixes issue: #620

The goal here is to be able to have one 'budget by kpi' for multiple companies.
Therefore, we need to be able to specify to which company a 'budget item' belongs

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@AnizR AnizR force-pushed the imp-mis-budget-by-kpi-company branch from 2c99b20 to 4d87e96 Compare August 28, 2024 13:22
@AnizR AnizR force-pushed the imp-mis-budget-by-kpi-company branch from 4d87e96 to 2158b41 Compare August 28, 2024 13:36
@AnizR AnizR force-pushed the imp-mis-budget-by-kpi-company branch from 2158b41 to 1a16239 Compare August 29, 2024 06:28
@AnizR
Copy link
Contributor Author

AnizR commented Aug 29, 2024

Small fix: I forgot to adapt the ir.rule to take into account company of mis.budget.item instead of using company of its related mis.budget

SAnnabelle
SAnnabelle approved these changes Aug 29, 2024
View reviewed changes
Copy link

@SAnnabelle SAnnabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally it's correct

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acsonefho acsonefho acsonefho approved these changes

@SAnnabelle SAnnabelle SAnnabelle approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnizR @OCA-git-bot @acsonefho @SAnnabelle