Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] ir_actions_report_multi_company: Migration from Odoo 13.0 to 16.0 #706

Open
wants to merge 9 commits into
base: 16.0
Choose a base branch
from

Conversation

GabbasovDinar
Copy link
Member

@GabbasovDinar GabbasovDinar commented Oct 9, 2024

The module was migrated in 13.0 by #364, this migration is on top of it.

@GabbasovDinar GabbasovDinar force-pushed the 16.0-t3976-ir_actions_report_multi_company-mig-to-16 branch 2 times, most recently from 1ad19cd to 67403f1 Compare October 15, 2024 11:20
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"""
cr.execute(query, (model_name, self.env.companies.ids))

report_ids = [report_id for report_id, report_type in cr.fetchall()]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report_type variable is not used. Please rename report_type on report_type_.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geomer198 renamed

@GabbasovDinar GabbasovDinar force-pushed the 16.0-t3976-ir_actions_report_multi_company-mig-to-16 branch from 67403f1 to 33445c2 Compare October 16, 2024 11:38
Copy link

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants