[15.0] move xml-deprecated-tree-attribute to optional checks ?

[sbidoul]

Question by @feketemihai on the mailing list

Example: OCA/l10n-romania#173

[feketemihai]

At least from my side this is quite usefull, so i don't know why this is deprecated but the at least the "string" tag, depending on some views it was easy to show different names, at least where you have one one2many field, but showed in 2 wotkflows, like separate it in customers and suppliers, and use 2 string for the same field. I agreed we can do it with label, but have to check if we have the same effect as the string in tree.

And if it's deprecated, as @pedrobaeza said, than Odoo should not use it no, but we have more than 100 example in the Odoo base code, so from my side i would move it to optional.

[pedrobaeza]

string attribute of <tree> tag is ignored since a long time AFAIK.

[sbidoul]

Can anyone find a reference from Odoo (in docs or source code) about this ?

[moylop260]

@sbidoul
Can anyone find a reference from Odoo (in docs or source code) about this ?

Notice the <!-- deprecated, has no effect anymore -->:

• https://github.com/odoo/odoo/blob/7c84886ebe2fd1aafa5743c7d61bbf0062aa55e1/odoo/addons/base/rng/tree_view.rng#L34

More info about:

• [RFC] Deprecated <tree> attributes pylint-odoo#146

[yajo]

FTR we can add it as optional in any version where it makes sense, as optional checks won't affect CI statuses.

[pedrobaeza]

But it's clear that the attribute doesn't make sense since a lot, so better to force to remove it for not confusing people about its usefulness, as Odoo has done in its core code with Fekete.

[yajo]

Ah I see, you mean to move it to optional from required.

Well, if it makes no sense, I'd just leave it as it is indeed.

[feketemihai]

Good, than i think we can close the issue. Thanks.