[15.0][MIG] base_sequence_option #2275

Rad0van · 2022-02-07T19:34:32Z

This would be a standard migration if only... I cannot force Odoo to run tests for this. Not in 15.0, not in 14.0 Anybody's got any idea why? So this is sort of an blind attempt based only on fact it seems to work together with account_sequence_option that I plan to port next. Had to add return statement here:

    @classmethod
    def tearDownClass(cls):
        cls.loader.restore_registry()
        return super(CommonBaseSequenceOption, cls).tearDownClass()

That's pretty strange because such code exists in Odoo itself (didn't look long enough to find such thing in OCA). Also had to remove string attribute from tree element in view definition as per OCA/oca-addons-repo-template#76 It was nagging as well.

Pylint was nagging me with
base_sequence_option/tests/common.py:91: [W8110(missing-return), CommonBaseSequenceOption.tearDownClass] Missing `return` (`super` is used) in method tearDownClass.

Any feedback welcome.

Rad0van · 2022-02-08T09:56:36Z

@kittiu would you have a look here please? Alsowhat does that ci/runboat failing at the beginning mean? @gurneyalex ?

kittiu · 2022-02-09T03:10:49Z

I can not see any runbot log. Can you somehow try to push again. May be you can squash commits and try again.
I am not sure what it is but some time I experiences ci/runbot just behave like that.
But as other test are passing, I believe it is eligible for merge too, if reviewed.

Rad0van · 2022-02-09T19:38:26Z

I can not see any runbot log. Can you somehow try to push again. May be you can squash commits and try again. I am not sure what it is but some time I experiences ci/runbot just behave like that. But as other test are passing, I believe it is eligible for merge too, if reviewed.

Even force-push didn't help. I cannot see anything there as well. Maybe @gurneyalex would know?

Rad0van · 2022-02-10T12:47:18Z

@kittiu can you see the tests being run? Because I cannot. The same happened to me at my local environments (14.0 and 15.o as well).

gurneyalex · 2022-02-28T11:14:17Z

runbot failing: please ignore, this is old story. Runboat seems to be running fine.

gurneyalex · 2022-02-28T11:17:12Z

To manually test on runboat:

click on the "Details" link next to the runboat/build check
Click on the start button on that page if you are not getting on an Odoo page directly, wait ~5s and then click on the "live" link -> this will get you to the Odoo login page.

Saran440 · 2022-11-15T10:56:38Z

@Rad0van Hello, do you still do this pr?

Rad0van · 2022-11-15T12:18:50Z

@Rad0van Hello, do you still do this pr?

Well what more can I do here?

Saran440 · 2022-11-16T10:09:22Z

@Rad0van runbot is gone. may be you can up-to-date code and push it again.

Rad0van · 2022-11-16T11:22:55Z

@Rad0van runbot is gone. may be you can up-to-date code and push it again.

Done ;-)

Saran440

Functional Test with OCA/hr-expense#149
LGTM 👍

Saran440 · 2022-11-17T04:11:19Z

base_sequence_option/__manifest__.py

+        "security/sequence_option_security.xml",
+        "views/sequence_option_view.xml",
+    ],
+    "license": "LGPL-3",


Suggested change

"license": "LGPL-3",

"license": "AGPL-3",

This module should AGPL-3 ?

Saran440 · 2022-11-17T04:12:06Z

base_sequence_option/__manifest__.py

@@ -0,0 +1,22 @@
+# Copyright 2021 Ecosoft Co., Ltd. (http://ecosoft.co.th)
+# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).


Suggested change

# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).

# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

All of license should agpl?

@Saran440 according to https://www.odoo-community.org/resources/faq AGPLv3, LGPLv3 or GPLv3 are possible. Also: I am not in a position to just "change" license of existing module I'm migrating. Only authors can do I believe.

okay, i will change it next PR.
cc: @kittiu

etobella · 2022-11-25T11:57:01Z

base_sequence_option/__manifest__.py

    "author": "Ecosoft, Odoo Community Association (OCA)",
    "maintainers": ["kittiu"],
    "development_status": "Alpha",
    "website": "https://github.com/OCA/server-tools",
    "category": "Tools",
    "depends": ["base"],
+    "external_dependencies": {"python": ["odoo_test_helper"]},


You don't need to add this here, just add it to test-requirements.txt (or create it if it does not exist 😄 )

OK, line removed. The test-requirements.txt already contains the odoo_test_helper so didn't do anything there. But it now causes pre-commit to fail. Not really sure I understand what's going on there.

Saran440 · 2023-03-20T04:10:21Z

@Rad0van Can you update your code again, please?

patrickt-oforce · 2023-11-03T11:08:21Z

@pedrobaeza hi, we tested this PR locally, and the pre-commit fail is due to wrong flake8 source url , that pointing to gitlab instead of github, can you make an OCABot rebase?

pedrobaeza · 2023-11-03T11:09:21Z

/ocabot rebase

OCA-git-bot · 2023-11-03T11:09:30Z

Congratulations, PR rebased to 15.0.

patrickt-oforce · 2023-11-03T11:22:02Z

@Rad0van i have made a pr versus your branch to fix pre-commit fails

matteoopenf · 2023-11-03T13:55:08Z

@Rad0van @patrickt-oforce have done a PR from your branch and it's that Rad0van#2 if you merge that the pre-commit works fine

Rad0van · 2023-11-03T14:00:57Z

@Rad0van @patrickt-oforce have done a PR from your branch and it's that Rad0van#2 if you merge that the pre-commit works fine

But that removes line from requirements.txt from whole repository. Not really sure that's the way to go...

matteoopenf · 2023-11-03T14:01:28Z

@Rad0van @patrickt-oforce have done a PR from your branch and it's that Rad0van#2 if you merge that the pre-commit works fine

But that removes line from requirements.txt from whole repository. Not really sure that's the way to go...

we have done a local test and works fine

patrickt-oforce · 2023-11-03T14:03:28Z

@Rad0van @patrickt-oforce have done a PR from your branch and it's that Rad0van#2 if you merge that the pre-commit works fine

But that removes line from requirements.txt from whole repository. Not really sure that's the way to go...

hi @Rad0van this deletion of requirements is operated by pre-commit, not our initiative; if you want can check results at #2749

matteoopenf · 2023-11-03T14:06:21Z

@Rad0van the pre-commit now works fine now you should squash the commit and we can ask the merge

matteoopenf · 2023-11-03T14:06:54Z

@etobella the pre-commit is now fix

Rad0van · 2023-11-03T14:27:21Z

@kittiu @etobella @Saran440 Rad0van with my collegue fix pre-commit and superseed #2749 can you have a look?

Isn't it rather the ocabot rebase fixed the precommit?

Rad0van · 2023-11-03T14:45:41Z

Sorry for the commit/squash mess. Have tried removing that "external_dependencies": {"python": ["odoo_test_helper"]} line from manifest but it keeps breaking despite that library being part of test-requirements.txt:

server-tools/test-requirements.txt

Line 1 in 6d2ffc7

odoo-test-helper

matteoopenf · 2023-11-03T14:48:52Z

Sorry for the commit/squash mess. Have tried removing that "external_dependencies": {"python": ["odoo_test_helper"]} line from manifest but it keeps breaking despite that library being part of test-requirements.txt:

server-tools/test-requirements.txt

Line 1 in 6d2ffc7

odoo-test-helper

have no sense is done by pre-commit.
So, anyway after that is ready to merge @Rad0van what do you think?

Rad0van · 2023-11-03T14:59:46Z

Sorry for the commit/squash mess. Have tried removing that "external_dependencies": {"python": ["odoo_test_helper"]} line from manifest but it keeps breaking despite that library being part of test-requirements.txt:

server-tools/test-requirements.txt

Line 1 in 6d2ffc7

odoo-test-helper

have no sense is done by pre-commit. So, anyway after that is ready to merge @Rad0van what do you think?

Now it passes. I have squashed all the commits so proper order is maintained. I think the rule is 2 approvals and 5 (or 7) days. Someone with rights need to merge it. I do not have those rights...

OCA-git-bot · 2023-11-03T15:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

matteoopenf · 2023-11-03T15:24:51Z

@pedrobaeza I think now is ready to merge.
Do you agree, or need something this pr?

patrickt-oforce · 2023-11-03T15:28:00Z

@Saran440 i think your PR #2743 and mine can be close; this PR now seem fixed and all check has green mark. About this PR OCA/account-financial-tools#1635 can you try to push an empty commit to restart CI?

pedrobaeza · 2023-11-03T15:40:41Z

Merging according reviews.

/ocabot migration base_sequence_option
/ocabot merge nobump

OCA-git-bot · 2023-11-03T15:40:57Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2275-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-11-03T16:00:40Z

Congratulations, your PR was merged at 53b20ee. Thanks a lot for contributing to OCA. ❤️

Rad0van force-pushed the 15.0-mig-base_sequence_option branch from 5374355 to f6ffc28 Compare February 9, 2022 07:51

Saran440 mentioned this pull request Nov 15, 2022

[15.0] [mig] base_sequence_option #2383

Closed

Rad0van force-pushed the 15.0-mig-base_sequence_option branch from f6ffc28 to 9e08e5a Compare November 16, 2022 11:15

Saran440 mentioned this pull request Nov 17, 2022

[15.0][MIG] hr_expense_sequence_option OCA/hr-expense#149

Merged

2 tasks

Saran440 approved these changes Nov 17, 2022

View reviewed changes

Saran440 reviewed Nov 17, 2022

View reviewed changes

etobella reviewed Nov 25, 2022

View reviewed changes

Saran440 mentioned this pull request Oct 27, 2023

[15.0][MIG] base_sequence_option #2743

Closed

kittiu and others added 5 commits November 3, 2023 11:09

[14.0][ADD] base_sequence_option

06f6a7b

Refactor for multi-company

483ab37

[UPD] Update base_sequence_option.pot

a41bd34

[UPD] README.rst

4cf6308

[IMP] base_sequence_option: black, isort, prettier

0b0531b

OCA-git-bot force-pushed the 15.0-mig-base_sequence_option branch from 4ca2f18 to c46165d Compare November 3, 2023 11:09

Rad0van force-pushed the 15.0-mig-base_sequence_option branch from 64379e5 to 0571ca8 Compare November 3, 2023 14:20

matteoopenf approved these changes Nov 3, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 3, 2023

[MIG] base_sequence_option: Migration to 15.0

9c842ec

Rad0van force-pushed the 15.0-mig-base_sequence_option branch from 964a6c1 to 9c842ec Compare November 3, 2023 14:43

OCA-git-bot added the ready to merge label Nov 3, 2023

patrickt-oforce approved these changes Nov 3, 2023

View reviewed changes

OCA-git-bot added this to the 15.0 milestone Nov 3, 2023

OCA-git-bot mentioned this pull request Nov 3, 2023

Migration to version 15.0 #2192

Open

54 tasks

OCA-git-bot added the bot is merging ⏳ label Nov 3, 2023

OCA-git-bot merged commit bdfb103 into OCA:15.0 Nov 3, 2023
9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 3, 2023

matteoopenf mentioned this pull request Nov 3, 2023

[15.0] [mig] account_sequence_option OCA/account-financial-tools#1455

Closed

		@@ -0,0 +1,22 @@
		# Copyright 2021 Ecosoft Co., Ltd. (http://ecosoft.co.th)
		# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).

	# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
	# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

[15.0][MIG] base_sequence_option #2275

[15.0][MIG] base_sequence_option #2275

Conversation

Rad0van commented Feb 7, 2022

Rad0van commented Feb 8, 2022

kittiu commented Feb 9, 2022

Rad0van commented Feb 9, 2022

Rad0van commented Feb 10, 2022

gurneyalex commented Feb 28, 2022

gurneyalex commented Feb 28, 2022

Saran440 commented Nov 15, 2022

Rad0van commented Nov 15, 2022

Saran440 commented Nov 16, 2022

Rad0van commented Nov 16, 2022

Saran440 left a comment

Choose a reason for hiding this comment

Saran440 Nov 17, 2022

Choose a reason for hiding this comment

Saran440 Nov 17, 2022

Choose a reason for hiding this comment

Rad0van Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

Saran440 Nov 18, 2022

Choose a reason for hiding this comment

etobella Nov 25, 2022

Choose a reason for hiding this comment

Rad0van Nov 25, 2022 • edited Loading

Choose a reason for hiding this comment

Saran440 commented Mar 20, 2023

patrickt-oforce commented Nov 3, 2023

pedrobaeza commented Nov 3, 2023

OCA-git-bot commented Nov 3, 2023

patrickt-oforce commented Nov 3, 2023

matteoopenf commented Nov 3, 2023 • edited Loading

Rad0van commented Nov 3, 2023

matteoopenf commented Nov 3, 2023

patrickt-oforce commented Nov 3, 2023 • edited Loading

matteoopenf commented Nov 3, 2023

matteoopenf commented Nov 3, 2023

Rad0van commented Nov 3, 2023

Rad0van commented Nov 3, 2023

matteoopenf commented Nov 3, 2023 • edited Loading

Rad0van commented Nov 3, 2023

OCA-git-bot commented Nov 3, 2023

matteoopenf commented Nov 3, 2023

patrickt-oforce commented Nov 3, 2023 • edited Loading

pedrobaeza commented Nov 3, 2023

OCA-git-bot commented Nov 3, 2023

OCA-git-bot commented Nov 3, 2023

Rad0van Nov 17, 2022 •

edited

Loading

Rad0van Nov 25, 2022 •

edited

Loading

matteoopenf commented Nov 3, 2023 •

edited

Loading

patrickt-oforce commented Nov 3, 2023 •

edited

Loading

matteoopenf commented Nov 3, 2023 •

edited

Loading

patrickt-oforce commented Nov 3, 2023 •

edited

Loading