Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintainer notification is broken ? #166

Closed
sbidoul opened this issue Dec 14, 2021 · 4 comments · Fixed by #174
Closed

Maintainer notification is broken ? #166

sbidoul opened this issue Dec 14, 2021 · 4 comments · Fixed by #174
Labels
bug Something isn't working

Comments

@sbidoul
Copy link
Member

sbidoul commented Dec 14, 2021

Describe the bug

I think I have seen somwhere that the the notification of maintainers when there is a new PR on their modules is not working anymore.
Is that correct ?
@sbidoul sbidoul added the bug Something isn't working label Dec 14, 2021
@pedrobaeza
Copy link
Member

pedrobaeza commented Dec 14, 2021 •
edited
Loading

Yes, I haven't seen it since a lot, but I remember you deactivate it somehow being very hammering.

@sbidoul
Copy link
Member Author

sbidoul commented Dec 14, 2021

What I deactivated is the call for maintainers when there is no declared maintainers because of #153.

@pedrobaeza
Copy link
Member

Then I don't know what is the reason, but it seems it's not working.

@sbidoul
Copy link
Member Author

sbidoul commented Dec 15, 2021

This was mentioned here by @LoisRForgeFlow

@sbidoul sbidoul mentioned this issue Apr 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mention maintainers acsone/oca-github-bot
2 participants
@sbidoul @pedrobaeza