[15.0][MIG] sql_request_abstract #552

mariadforgeflow · 2021-12-02T11:26:48Z

Standard migration to v15.
Module moved from server-tools.
@JoanMForgeFlow
@lmignon could you take a look and if you think it's okay merge it? Thank you!

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/

Currently translated at 100.0% (21 of 21 strings) Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/zh_CN/

Currently translated at 100.0% (21 of 21 strings) Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/

mariadforgeflow · 2021-12-02T11:43:50Z

Hi.

This module sql_request_abstract is shared between many modules :

bi_sql_editor (in reporting-engine)

sql_export and co (in server-tools)

so, 2 options :

leave sql_request_abstract in server-tools

move also sql_export & co in reporting-engine. (that case, please add a section in the ROADMAP.rst section of last revision of the related modules).

otherwise, that move makes no senses.

What do you think ?

LGTM Otherwise. Thanks for porting this module.

Note : Why oca-bot didn't ping me with a message like "A module you are maintaining has been modified" ?

Hi! I moved it from server-tools because in this module Roadmap in v14 said so: "Move modules sql_request_abstract and sql_export to oca/reporting-engine for version 15". I will now move sql_export also:)

BTW what do you exactly mean with "please add a section in the ROADMAP.rst section of last revision of the related modules)."?

Thank you!

legalsylvain

I will now move sql_export also:)

BTW what do you exactly mean with "please add a section in the ROADMAP.rst section of last revision of the related modules)."?

I didn't know you has planned to move also sql_export. If you move it, all is OK, and you don't to add any text in the roadmap section.

kind regards.

legalsylvain · 2021-12-02T12:10:14Z

Hi maintainers, could you approve workflow ?
thanks.

LoisRForgeFlow · 2021-12-03T08:16:00Z

Note : Why oca-bot didn't ping me with a message like "A module you are maintaining has been modified" ?

That is a nice question, it was a nice feature, but it's been a while since the last message of that kind I saw.

LoisRForgeFlow

Code review LGTM 👍

LoisRForgeFlow · 2021-12-03T08:18:06Z

/ocabot merge nobump

OCA-git-bot · 2021-12-03T08:18:23Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-552-by-LoisRForgeFlow-bump-nobump, awaiting test results.

Signed-off-by LoisRForgeFlow

OCA-git-bot · 2021-12-03T08:22:14Z

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-552-by-LoisRForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

LoisRForgeFlow · 2021-12-03T08:25:16Z

Note : Why oca-bot didn't ping me with a message like "A module you are maintaining has been modified" ?

That is a nice question, it was a nice feature, but it's been a while since the last message of that kind I saw.

Hi @sbidoul, hope you can help us with two doubts.

The first one is above, why there is no maintainer mentions from the bot anymore?
The merge failed due to the cache of the pre-commit job (https://github.com/OCA/reporting-engine/runs/4405605005?check_suite_focus=true), this is not the first time I see this problem. Is there a way to easily invalidate the cache to solve this problem?

LoisRForgeFlow · 2021-12-09T15:06:12Z

/ocabot merge nobump

OCA-git-bot · 2021-12-09T15:06:31Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-552-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2021-12-09T15:10:09Z

Congratulations, your PR was merged at 49c7c7b. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 30 commits December 2, 2021 12:14

create a new module sql_request_abstract

d496c9e

Fix version

4a06873

various improvement. Courtesy @dreispt review

fd2a7c9

OCA Transbot updated translations from Transifex

7734185

OCA Transbot updated translations from Transifex

9f09321

[MIG] sql_request_abstract v10

1355fa6

OCA Transbot updated translations from Transifex

ce19486

remove obsolete .pot files [ci skip]

1890774

[UPD] Update sql_request_abstract.pot

4a11c43

[FIX] mogrify doesn't allow dicts

f9afb9d

[UPD] Update sql_request_abstract.pot

8546e6d

[MIG] sql_request_abstract: Migration to 11.0

8a523bb

[UPD] Update sql_request_abstract.pot

d35bd7e

Update translation files

cc4f386

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[12.0][MIG] Migrate module sql_request_abstract to v12

7638092

[UPD] README.rst

72e28b2

[UPD] Update sql_request_abstract.pot

ac0f5f3

Update translation files

48c49e2

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/

FIX sql_request_abstract: b64encode use a Bytes like object

a46e6d2

[UPD] Update sql_request_abstract.pot

c311ddc

Update translation files

1055695

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/

[UPD] README.rst

c7e60f5

ADD module mrp_component_consumption_gap

8397515

[UPD] Update sql_request_abstract.pot

e016e59

Update translation files

f004441

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/

[IMP] sql_request_abstract black, isort

6bdfec6

[MIG] sql_request_abstract: Migration to 13.0

d6ef7b1

[UPD] Update sql_request_abstract.pot

8165f99

mariadforgeflow force-pushed the 15-mig-sql_request_abstract branch from 32e161d to 7d1971b Compare December 2, 2021 11:48

legalsylvain approved these changes Dec 2, 2021

View reviewed changes

OCA-git-bot added the approved label Dec 2, 2021

[MIG] sql_request_abstract: Migration to 15.0

e495e07

mariadforgeflow force-pushed the 15-mig-sql_request_abstract branch from 7d1971b to e495e07 Compare December 2, 2021 12:17

mariadforgeflow changed the title ~~[15.0][MIG] mig_sql_request_abstract~~ [15.0][MIG] sql_request_abstract Dec 2, 2021

LoisRForgeFlow approved these changes Dec 3, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 3, 2021

OCA-git-bot added a commit that referenced this pull request Dec 3, 2021

Merge PR #552 into 15.0

3d6395b

Signed-off-by LoisRForgeFlow

LoisRForgeFlow mentioned this pull request Dec 3, 2021

Migration to version 15.0 OCA/server-tools#2192

Open

54 tasks

OCA-git-bot removed the bot is merging ⏳ label Dec 3, 2021

OCA-git-bot added the bot is merging ⏳ label Dec 9, 2021

OCA-git-bot merged commit 7b78f3d into OCA:15.0 Dec 9, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 9, 2021

LoisRForgeFlow deleted the 15-mig-sql_request_abstract branch December 10, 2021 07:40

sbidoul mentioned this pull request Dec 15, 2021

Maintainer notification is broken ? OCA/oca-github-bot#166

Closed

sebalix mentioned this pull request Jan 31, 2022

[15.0][MIG] sql_request_abstract: Migration to 15.0 OCA/server-tools#2263

Closed

sebalix added the migration label Jan 31, 2022

sebalix added this to the 15.0 milestone Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] sql_request_abstract #552

[15.0][MIG] sql_request_abstract #552

mariadforgeflow commented Dec 2, 2021 •

edited

Loading

mariadforgeflow commented Dec 2, 2021 •

edited

Loading

legalsylvain left a comment

legalsylvain commented Dec 2, 2021

LoisRForgeFlow commented Dec 3, 2021

LoisRForgeFlow left a comment

LoisRForgeFlow commented Dec 3, 2021

OCA-git-bot commented Dec 3, 2021

OCA-git-bot commented Dec 3, 2021

LoisRForgeFlow commented Dec 3, 2021

LoisRForgeFlow commented Dec 9, 2021

OCA-git-bot commented Dec 9, 2021

OCA-git-bot commented Dec 9, 2021

[15.0][MIG] sql_request_abstract #552

[15.0][MIG] sql_request_abstract #552

Conversation

mariadforgeflow commented Dec 2, 2021 • edited Loading

mariadforgeflow commented Dec 2, 2021 • edited Loading

legalsylvain left a comment

Choose a reason for hiding this comment

legalsylvain commented Dec 2, 2021

LoisRForgeFlow commented Dec 3, 2021

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Dec 3, 2021

OCA-git-bot commented Dec 3, 2021

OCA-git-bot commented Dec 3, 2021

LoisRForgeFlow commented Dec 3, 2021

LoisRForgeFlow commented Dec 9, 2021

OCA-git-bot commented Dec 9, 2021

OCA-git-bot commented Dec 9, 2021

mariadforgeflow commented Dec 2, 2021 •

edited

Loading

mariadforgeflow commented Dec 2, 2021 •

edited

Loading