[18.0][MIG] partner_ref_unique #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contraint is self-disabled when it detects by context that it is being used from the contact deduplicator. Otherwise, the user cannot deduplicate a contact selecting the "good" one as the one without reference. Anyway, in these cases, the check has no meaning, since it is to avoid duplicates and in this context we are currently removing them.
- Added OCA icon
OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex
Currently translated at 100.0% (8 of 8 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_ref_unique/hr/
Before this commit, the partner_ref_unique could be changed on the company even if existing partners share the same internal ref. Therefore, errors will appear afterwards as DB already contains duplicates although the policy shouldn't allow it. With this change, the error will appear as soon as the policy is changed, so that the data must be fixed before activating the constraint.
…ompany Add pre_init_hook to speed up module installation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-12.0/partner-contact-12.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_ref_unique/
Currently translated at 100.0% (8 of 8 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_ref_unique/es/
Currently translated at 100.0% (8 of 8 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_ref_unique/de/
If merging 2 contacts, one with reference, and another without, and being the target one the contact without reference, the constraint is raised as the reference value is copied before unlinking the other contact. We avoid it disabling the constraint when merging.
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-15.0/partner-contact-15.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-15-0/partner-contact-15-0-partner_ref_unique/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-16.0/partner-contact-16.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_ref_unique/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_ref_unique/es/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_ref_unique/fr/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_ref_unique/fr_FR/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-16.0/partner-contact-16.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-partner_ref_unique/it/
Currently translated at 100.0% (9 of 9 strings) Translation: partner-contact-17.0/partner-contact-17.0-partner_ref_unique Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-partner_ref_unique/sv/
|
@pedrobaeza this PR is ready :) |
pedrobaeza
changed the title
pedrobaeza
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
/ocabot migration partner_ref_unique
@samirGuesmi please next time put the proper title like the one I have put.
/ocabot merge nobump
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f315daf. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.