[18.0][MIG] partner_title_order: Migration to 18.0 #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_title_order Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_title_order/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_title_order Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_title_order/es/
TDu
approved these changes
Oct 18, 2024
| @@ -14,7 +14,7 @@ def test_default_order(self): | |||
| partner_titles = self.env["res.partner.title"].search([]) | |||
| self.assertEqual( | |||
| partner_titles.mapped("name"), | |||
| partner_titles.sorted(lambda x: x.name).mapped("name"), | |||
| partner_titles.sorted(lambda x: (x.sequence, x.name)).mapped("name"), | |||
There was a problem hiding this comment.
Was this change because the test failed ?
IMO it should not have, all sequence fields should have been set to 10 ?
Just a question to understand the change.
There was a problem hiding this comment.
That was my mistake! There was a bit of confusion between two test cases, which led to my change in that part.
Kimkhoi3010
force-pushed
the
18.0-mig-partner_title_order
branch
from
40cba64
to
340a7f5
Compare
|
/ocabot migration partner_title_order |
|
|
||
|
|
||
| class TestPartnerTitle(SavepointCase): | ||
| class TestPartnerTitle(common.TransactionCase): |
There was a problem hiding this comment.
@Kimkhoi3010 FYI, to avoid the tracking_disable context change here under, you can use BaseCommon class from base addon instead.
There was a problem hiding this comment.
hello @rousseldenis thanks for your time.
Kimkhoi3010
force-pushed
the
18.0-mig-partner_title_order
branch
from
340a7f5
to
8c6150b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.