Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] sale_partner_company_group: Migration to 18.0 #1874

Open
wants to merge 18 commits into
base: 18.0
Choose a base branch
from

Conversation

nguyenminhchien
Copy link

@nguyenminhchien nguyenminhchien commented Oct 16, 2024

yankinmax and others added 18 commits October 16, 2024 15:08
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-16.0/partner-contact-16.0-sale_partner_company_group
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-sale_partner_company_group/
Currently translated at 100.0% (5 of 5 strings)

Translation: partner-contact-16.0/partner-contact-16.0-sale_partner_company_group
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-sale_partner_company_group/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-17.0/partner-contact-17.0-sale_partner_company_group
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-sale_partner_company_group/
Currently translated at 100.0% (5 of 5 strings)

Translation: partner-contact-17.0/partner-contact-17.0-sale_partner_company_group
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-17-0/partner-contact-17-0-sale_partner_company_group/it/
Copy link
Member

@mmequignon mmequignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny remark, looking good

Comment on lines 13 to 14
# Remove this variable in v16 and put instead:
# from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't we supposed to import DISABLED_MAIL_CONTEXT ?
Is it coming from TestBasePartnerCompanyGroup->BaseCommon ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.

class TestBasePartnerCompanyGroup(BaseCommon):

@rousseldenis
Copy link
Contributor

/ocabot migration sale_partner_company_group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.