[17.0][MIG] pos_lot_selection: Migration to 17.0 #1106

nguyenminhchien · 2023-12-07T04:35:25Z

ref: BSRD-704

With PR odoo/odoo#23698 merged, clone control is no longer needed for lots. [FIX] pos_lot_selection: group lots by quants fixup! [FIX] pos_lot_selection: group lots by quants fixup! fixup! [FIX] pos_lot_selection: group lots by quants

Object.assign is introduced in ES6 (2015) which is not supported by PhantomJS. Replace it with the equivalent _.extend function to prevent frontend tests from failing. 1. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Specifications 2. ariya/phantomjs#14506

Currently translated at 100.0% (1 of 1 strings) Translation: pos-11.0/pos-11.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_lot_selection/ca/

Regular Point of Sale Users with the minimal access rights are not allowed to read the `stock.production.lot` model.

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/it/

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/es/

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/it/

gurneyalex · 2023-12-07T19:34:24Z

/ocabot migration pos_lot_selection

Fabrizio1305 · 2023-12-11T09:24:19Z

It works
(but I have a bug that I think is not related to the module, but to odoo, as it happens also without the module)
Tested flow:

activate lots on products
take a product available in POS, and update qty to create an entry with a LOT (make sure the lot number doesn't exist yet for any product), make sure the product doesn't have qty in stock without a LOT (to avoid inconsistencies).
Create a second and third LOT on the same product, one of them with quantities and one without
open POS
add that product to a cart the standard way
on the lot selection popup, a drop down menu should appear with the choice of lots that are in stock, choose one of them
finalize the transaction by paying in cash and closing the POS
and double check that the proper product and lot has been taken out of stock (inventory moves)

The flow worked, but on point 8, in the POS session data I have the correct lot sold, but in the inventory app I have another lot being delivered. I think this is an odoo bug rather than this module's bug as it also happens without the module.
tested with and without #1105 pos_lot_barcode

etobella · 2024-01-05T14:49:46Z

@nguyenminhchien I made the migration but made it compatible with an offline PoS. Do you prefer that I make a PR directly to your PR or should I made a new one (I would keep part of your code regarding to tests for example)

nguyenminhchien · 2024-01-08T03:37:47Z

@nguyenminhchien I made the migration but made it compatible with an offline PoS. Do you prefer that I make a PR directly to your PR or should I made a new one (I would keep part of your code regarding to tests for example)

Please create a pull request to my branch nguyenminhchien:17.0-mig-pos_lot_selection, thanks.

etobella · 2024-01-08T10:16:41Z

I made the PR:

nguyenminhchien#3

Can you review it?

nguyenminhchien · 2024-01-12T09:02:28Z

I made the PR:

nguyenminhchien#3

Can you review it?

@etobella hi, i merged your commit but the test was failed, please check it. thanks.

etobella · 2024-01-12T10:07:02Z

I made the fix, it was just a small typo error on the last change 😞

cvinh · 2024-01-15T22:56:22Z

I made the PR:
nguyenminhchien#3
Can you review it?

@etobella hi, i merged your commit but the test was failed, please check it. thanks.

Hello, new PR here nguyenminhchien#4

cvinh

Functional tests ok

etobella

/ocabot merge nobump

OCA-git-bot · 2024-01-17T16:55:45Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1106-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-17T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-01-17T17:01:28Z

Congratulations, your PR was merged at 1d07940. Thanks a lot for contributing to OCA. ❤️

chienandalu and others added 28 commits November 30, 2023 14:20

[10.0][ADD] pos_lot_selection: New module (OCA#256)

0b3c0dc

[UPD] Update pos_lot_selection.pot

8ec08fe

[MIG] pos_lot_selection: Migration to 11.0

bcdf4ad

[UPD] Update pos_lot_selection.pot

1ab45ad

Added translation using Weblate (Catalan)

0f45849

Translated using Weblate (Catalan)

110da6b

Currently translated at 100.0% (1 of 1 strings) Translation: pos-11.0/pos-11.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-11-0/pos-11-0-pos_lot_selection/ca/

[MIG] pos_lot_selection

4c4440e

[UPD] Update pos_lot_selection.pot

add5bdc

[UPD] README.rst

12e073f

[FIX] pos_lot_selection: proper module name in js definition

b6105b5

[FIX] pos_lot_selection: access rights

ecc1cb8

Regular Point of Sale Users with the minimal access rights are not allowed to read the `stock.production.lot` model.

[IMP] pos_lot_selection: bump js to es6

f6c6e6c

[IMP] pos_lot_selection: avoid replace in xml views, simplify code

51200fb

[UPD] Update pos_lot_selection.pot

89459d8

pos_lot_selection 15.0.1.0.1

49b052e

[MIG] pos_lot_selection: Migration to 16.0

601355d

[UPD] Update pos_lot_selection.pot

33a03ce

Added translation using Weblate (Italian)

2221f88

Translated using Weblate (Italian)

96f4c69

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/it/

Added translation using Weblate (Spanish)

2052617

Translated using Weblate (Italian)

8de976e

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/it/

Translated using Weblate (Spanish)

a7698f6

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/es/

[UPD] README.rst

ada368e

Translated using Weblate (Italian)

cff55df

Currently translated at 100.0% (2 of 2 strings) Translation: pos-16.0/pos-16.0-pos_lot_selection Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_lot_selection/it/

[IMP] pos_lot_selection: pre-commit auto fixes

273888f

[MIG] pos_lot_selection: Migration to 17.0

5f4f759

nguyenminhchien marked this pull request as ready for review December 7, 2023 07:19

nguyenminhchien mentioned this pull request Dec 7, 2023

Migration to version 17.0 #1077

Open

30 tasks

OCA-git-bot added this to the 17.0 milestone Dec 7, 2023

Fabrizio1305 mentioned this pull request Dec 11, 2023

[17.0][MIG] pos_lot_barcode: Migration to 17.0 #1105

Merged

nguyenminhchien force-pushed the 17.0-mig-pos_lot_selection branch from e031ae0 to 5f4f759 Compare January 12, 2024 09:23

[REF] pos_lot_selection: Make it work properly on offline mode

115bde5

nguyenminhchien force-pushed the 17.0-mig-pos_lot_selection branch from 4605a74 to 115bde5 Compare January 17, 2024 02:41

cvinh approved these changes Jan 17, 2024

View reviewed changes

etobella approved these changes Jan 17, 2024

View reviewed changes

OCA-git-bot added the approved label Jan 17, 2024

OCA-git-bot added bot is merging ⏳ ready to merge labels Jan 17, 2024

OCA-git-bot merged commit f6322d2 into OCA:17.0 Jan 17, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] pos_lot_selection: Migration to 17.0 #1106

[17.0][MIG] pos_lot_selection: Migration to 17.0 #1106

nguyenminhchien commented Dec 7, 2023

gurneyalex commented Dec 7, 2023

Fabrizio1305 commented Dec 11, 2023 •

edited

Loading

etobella commented Jan 5, 2024

nguyenminhchien commented Jan 8, 2024

etobella commented Jan 8, 2024

nguyenminhchien commented Jan 12, 2024

etobella commented Jan 12, 2024

cvinh commented Jan 15, 2024

cvinh left a comment

etobella left a comment

OCA-git-bot commented Jan 17, 2024

OCA-git-bot commented Jan 17, 2024

OCA-git-bot commented Jan 17, 2024

[17.0][MIG] pos_lot_selection: Migration to 17.0 #1106

[17.0][MIG] pos_lot_selection: Migration to 17.0 #1106

Conversation

nguyenminhchien commented Dec 7, 2023

gurneyalex commented Dec 7, 2023

Fabrizio1305 commented Dec 11, 2023 • edited Loading

etobella commented Jan 5, 2024

nguyenminhchien commented Jan 8, 2024

etobella commented Jan 8, 2024

nguyenminhchien commented Jan 12, 2024

etobella commented Jan 12, 2024

cvinh commented Jan 15, 2024

cvinh left a comment

Choose a reason for hiding this comment

etobella left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 17, 2024

OCA-git-bot commented Jan 17, 2024

OCA-git-bot commented Jan 17, 2024

Fabrizio1305 commented Dec 11, 2023 •

edited

Loading