-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] pos_report_session_summary #1190
Conversation
/ocabot migration pos_report_session_summary |
@zamberjo Could you update the status of this PR? I am interested in the migration. |
28809dc
to
e8a341d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zamberjo I tested and encountered an error. Please check my comments.
Additionally, you should split commits (one for precommit and another for migration) according to the guidelines in https://github.com/oca/maintainer-tools/wiki/Migration-to-version-16.0
TT49806
</tr> | ||
</thead> | ||
<tbody> | ||
<tr t-foreach="o.statement_ids" t-as="statement"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<tr t-foreach="o.statement_ids" t-as="statement"> | ||
<td><span t-field="statement.name" /></td> | ||
<td><span t-field="statement.journal_id" /></td> | ||
<td class="text-right"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update class to BT5
https://getbootstrap.com/docs/5.0/migration/#utilities
<td class="text-right"> | |
<td class="text-end"> |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-15.0/pos-15.0-pos_report_session_summary Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_report_session_summary/
… 'str' object has no attribute 'decimal_places' when printing session summaryossible to print the report. This pr fixes the error: 'str' object has no attribute 'decimal_places' when printing session summary
e8a341d
to
19e7ad4
Compare
Hi @carlos-lopez-tecnativa , I just did a rebase, I'm going to take this up again and do what you told me. I will let you know as soon as I have it ready for review. |
1969181
to
1444855
Compare
1444855
to
b68b6a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zamberjo I left my comments. If you have any questions, please let me know.
</thead> | ||
<tbody> | ||
<tr | ||
t-foreach="o.statement_line_ids.mapped('statement_id')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to use pos.payment
instead of account.bank.statement.line
. Please review this model and field. If pos.session
does not have a field to pos.payment
, you can add this field as one2many
or include it in the report by performing a read_group
to get all related payment information.
Remember that account.bank.statement
is no longer required and Odoo does not create records in this model from POS.
<th>Partner</th> | ||
<th>Partner</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is repeat twice?
@zamberjo, could you please update the status of this PR? |
Hi @carlos-lopez-tecnativa , unfortunately I have been caught in the middle of several migrations and holydays. If you need it very urgently you can continue it since I don't know when I will be able to resume it. |
No description provided.