[16.0][MIG] pos_customer_required_fields: Migration to 16.0 #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure desired fields are collect on customer Pos Order
In case there is no required field we don't want to lock user on payment screen. As required fields list is stored in string variable spliting an empty string return an array of one empty string which would return one missing field which is locking users
Currently translated at 10.0% (1 of 10 strings) Translation: pos-12.0/pos-12.0-pos_customer_required_fields Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_customer_required_fields/it/
Currently translated at 100.0% (10 of 10 strings) Translation: pos-12.0/pos-12.0-pos_customer_required_fields Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_customer_required_fields/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_customer_required_fields Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_customer_required_fields/
legalsylvain
reviewed
Oct 1, 2024
Comment on lines
17
to
18
| "base", | ||
| "base_setup", |
There was a problem hiding this comment.
don't understand that addition. could you elaborate ?
There was a problem hiding this comment.
well, I think it's just a mistake, I remove it
LaetitiaElabore
force-pushed
the
16.0-mig-pos_customer_required_fields
branch
from
3a1a0be
to
e4196f2
Compare
LaetitiaElabore
changed the title
LaetitiaElabore
force-pushed
the
16.0-mig-pos_customer_required_fields
branch
from
e4196f2
to
f9e826e
Compare
b0g
reviewed
Oct 8, 2024
Comment on lines
+65
to
+71
| .. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_customer_required_fields/static/description/pos_edit_customer.png | ||
|
|
||
| If you choose an existing partner with missing informations | ||
| while validating the payment you will be ask to collect missing | ||
| customer informations. | ||
|
|
||
| .. figure:: https://raw.githubusercontent.com/OCA/pos/16.0/pos_customer_required_fields/static/description/pos_customer_missing_fields.png |
There was a problem hiding this comment.
This links are broken,
Beside that I tested the module and it work as expected !
There was a problem hiding this comment.
Thanks @b0g for the review and the feedback. I’ll fix the broken links.
There was a problem hiding this comment.
I suppose the broken link is normal until the branch is not merged!
petrus-v
approved these changes
Oct 8, 2024
| @@ -0,0 +1,4 @@ | |||
| # from . import res_partner | |||
There was a problem hiding this comment.
This line seems useless
Suggested change
| # from . import res_partner |
There was a problem hiding this comment.
thanks @petrus-v for the feed back, I have just pushed the modification you suggested (and added some modification in translation files)
There was a problem hiding this comment.
a screenshot of v12 has been replaced by one of v16
LaetitiaElabore
force-pushed
the
16.0-mig-pos_customer_required_fields
branch
from
f9e826e
to
38c31ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@petrus-v
migration of pos_customer_required_fields from 12.0 to 16.0 (with commits history)