Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [IMP] pos_picking_load: returning widgets so they can be inherited #535

Merged
merged 1 commit into from
Sep 9, 2020
Merged

[12.0] [IMP] pos_picking_load: returning widgets so they can be inherited #535

merged 1 commit into from
Sep 9, 2020

Conversation

Du-ma
Copy link
Member

@Du-ma Du-ma commented Sep 9, 2020

All new widgets should be returned.
Because right now there isn't really a way to inherit the widget and add some functionality to it.

@OCA-git-bot
Copy link
Contributor

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Du-ma.

thanks for your contribution. LGTM.
Is it for custom needs ? or do you will to developp an extra OCA module ? Curious to know what are your needs.

Fast tracking trivial patch.

/ocabot merge patch

@Du-ma
Copy link
Member Author

Du-ma commented Sep 9, 2020

Hey @legalsylvain , cheers for the fast reaction.

I'm making a custom need module for a client. And some of the needs include spicing the javascript part up a bit 😁

@legalsylvain
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-535-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 9, 2020
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-535-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cca5172 into OCA:12.0 Sep 9, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f7d3ec7. Thanks a lot for contributing to OCA. ❤️

@Du-ma Du-ma deleted the 12.0-imp-pos_picking_load branch September 10, 2020 06:10
manuelregidor pushed a commit to sygel-technology/pos that referenced this pull request Jun 28, 2021
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
legalsylvain pushed a commit to legalsylvain/pos that referenced this pull request Oct 7, 2022
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request Mar 31, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request Mar 31, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request Mar 31, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request Apr 3, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request Apr 19, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
anmarmo1 pushed a commit to aurestic/pos that referenced this pull request May 3, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request May 4, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
anmarmo1 pushed a commit to aurestic/pos that referenced this pull request May 5, 2023
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
zamberjo pushed a commit to aurestic/pos that referenced this pull request Jan 9, 2024
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
anmarmo1 pushed a commit to aurestic/pos that referenced this pull request Jan 25, 2024
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
vasi26ro pushed a commit to vasi26ro/pos that referenced this pull request Feb 12, 2024
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
anmarmo1 pushed a commit to aurestic/pos that referenced this pull request May 2, 2024
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
chaule97 pushed a commit to chaule97/pos that referenced this pull request Aug 21, 2024
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
chaule97 pushed a commit to chaule97/pos that referenced this pull request Sep 18, 2024
Return module's javascript widgets to make them extendable for other modules.

Same idea as OCA#535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants