Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] sale_product_pack: Respect the order of the lines to be added #186

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FIX] sale_product_pack: Respect the order of the lines to be added #186

wants to merge 1 commit into from

Conversation

victoralmau
Copy link
Member

Respect the order of the lines to be added

Before
antes

After
despues

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT51380

@OCA-git-bot
Copy link
Contributor

Hi @ernestotejeda,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 21, 2024
pedrobaeza
pedrobaeza reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are losing here a lot of performance, as this applies to all sales order lines, no matter if with pack or not.

Aren't there any other option for this?

@victoralmau victoralmau force-pushed the 16.0-fix-sale_product_pack-TT51380 branch from 7d873ac to c4e1ddb Compare October 21, 2024 10:53
@victoralmau
Copy link
Member Author

We are losing here a lot of performance, as this applies to all sales order lines, no matter if with pack or not.

Aren't there any other option for this?

Changed so that it only applies when any line that is created is a pack.

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 21, 2024 •
edited
Loading

But it still has the problem with large orders containing packs. You have to find another alternative. How it was done in previous versions? What is the difference now?

@victoralmau
Copy link
Member Author

v15 code: https://github.com/OCA/product-pack/blob/15.0/sale_product_pack/models/sale_order_line.py#L79
After creating each of the lines, the extra lines of the pack were auto-created (if applicable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@victoralmau @OCA-git-bot @pedrobaeza