[REF]: update to pylint 3.0.0, drop support for py3.7 #474
Conversation
Pylint 3.0.0 has been released and with it a bunch of fixes and improvements. This repository has been updated to depend on this new version. BREAKING CHANGE: Pylint 3.0.0 drops support for Python 3.7 so this plugin no longer supports Python 3.7 as well. Related OCA#473.
Pylint v3.0.0 changed some of its behaviour externally (to users) and internally as well (for developers) by depending on a newer release of astroid. Code has been updated to work with said changes and fix the current test suite. Specifically astroid has dropped support for visit_tryexcept and other friends, replacing it by visit_try. Pylint's invalid check no longer checks for a minimum length of three characters as well, so the expected messages had to be updated. Closes OCA#473.
antonag32
force-pushed
the
pylint3-anton
branch
from
1ccf06e
to
0db1c27
Compare
|
I think this could be merged, just wondering if we should merge this into main and create a 8.0 branch if any backport fixes are needed in the future. I like the idea and it seems that it was the same path taken when releasing version 8 (when lots of checks were moved to oca hooks). |
requirements.txt
Outdated
| @@ -1,3 +1,3 @@ | |||
| pylint-plugin-utils==0.7 | |||
| pylint==2.15.* | |||
| pylint>=3, <4 | |||
There was a problem hiding this comment.
Please, pin the pylint version in order to avoid adding new lints and creating new CI red without an explicit validation from our side and advice to our team and community
|
Please, consider the following extra steps:
|
Pylint 3.0.0 has been released and with it a bunch of fixes and improvements. This repository has been updated to depend on this new version. BREAKING CHANGE: Pylint 3.0.0 drops support for Python 3.7 so this plugin no longer supports Python 3.7 as well. * update code to work with pylint v3 Pylint v3.0.0 changed some of its behaviour externally (to users) and internally as well (for developers) by depending on a newer release of astroid. Code has been updated to work with said changes and fix the current test suite. Specifically astroid has dropped support for visit_tryexcept and other friends, replacing it by visit_try. Pylint's invalid check no longer checks for a minimum length of three characters as well, so the expected messages had to be updated. Closes #473.
Pylint 3.0.0 has been released and with it a bunch of fixes and improvements. This repository has been updated to depend on this new version.
BREAKING CHANGE: Pylint 3.0.0 drops support for Python 3.7 so this plugin no longer supports Python 3.7 as well.
Closes #473.