Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] queue_job_cron: channel_id must be storable. #355

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

LoisRForgeFlow
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow commented Jun 11, 2021

Otherwise, you cannot use any channel other than default (
root.ir_cron)

The struggle was real without this fix 😢 :
Peek 2021-06-11 16-13

After the fix life is great 😄 :
Peek 2021-06-11 16-19

@ForgeFlow

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense

Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LoisRForgeFlow
Copy link
Contributor Author

@guewen Do you think this is enough?, or it is better to use an extra field manual_channel_id and rely on that one for the compute ensuring that it won't get back to False if the compute is triggered.

@guewen
Copy link
Member

guewen commented Jun 13, 2021

@guewen Do you think this is enough?, or it is better to use an extra field manual_channel_id and rely on that one for the compute ensuring that it won't get back to False if the compute is triggered.

With the new compute methods of 13.0, we can make it work like a default value:

for cron in self:
    if cron.channel_id:
        continue
    if cron.run_as_queue_job:
        cron.channel_id = ...

That being said, I'm not sure why this field has to be computed.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Otherwise, you cannot use any channel other than default (
root.ir_cron)
@LoisRForgeFlow
Copy link
Contributor Author

@guewen I added the continue clause, I think that makes sense. For me this is good to merge.

@guewen
Copy link
Member

guewen commented Jun 22, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-355-by-guewen-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 03e662d into OCA:13.0 Jun 22, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aabec4c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants