-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][FIX] queue_job_cron: channel_id must be storable. #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@guewen Do you think this is enough?, or it is better to use an extra field |
With the new compute methods of 13.0, we can make it work like a default value:
That being said, I'm not sure why this field has to be computed. |
This PR has the |
1 similar comment
This PR has the |
Otherwise, you cannot use any channel other than default ( root.ir_cron)
2579d4d
to
78b69bf
Compare
@guewen I added the continue clause, I think that makes sense. For me this is good to merge. |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at aabec4c. Thanks a lot for contributing to OCA. ❤️ |
Otherwise, you cannot use any channel other than default (
root.ir_cron)
The struggle was real without this fix 😢 :
After the fix life is great 😄 :
@ForgeFlow