Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] queue_job_subscribe: Migration to 16.0 #548

Merged
merged 3 commits into from
Sep 25, 2023
Merged

[16.0][MIG] queue_job_subscribe: Migration to 16.0 #548

merged 3 commits into from
Sep 25, 2023

Conversation

ramiadavid
Copy link
Contributor

No description provided.

kikopeiro
kikopeiro approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@kikopeiro kikopeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (without code review)

👍

@julenfl
Copy link

julenfl commented Jul 20, 2023

Hi @vincent-cowboy @amh-mw , could you take a look to this PR?

Thanks!

@mymage @ramiadavid
Translated using Weblate (Italian)
16861f0 
Currently translated at 100.0% (5 of 5 strings)

Translation: queue-15.0/queue-15.0-queue_job_subscribe
Translate-URL: https://translation.odoo-community.org/projects/queue-15-0/queue-15-0-queue_job_subscribe/it/
@ramiadavid ramiadavid force-pushed the 16.0-mig-queue_job_subscribe branch from ab5ceb5 to 766622f Compare July 30, 2023 17:07
@julenfl
Copy link

julenfl commented Jul 31, 2023

Hi @guewen @sbidoul @ivantodorovich ,

Could someone please merge this PR, it seems correct

Thank you

@julenfl
Copy link

julenfl commented Sep 6, 2023

Hi @guewen @sbidoul @ivantodorovich ,

Can someone check this PR, it seems correct, sorry for the insistence.

ivantodorovich
ivantodorovich approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I'm not really familiar with this module, but the migration looks good 👍🏻

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

simahawk commented Sep 7, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-548-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 7, 2023
@OCA-git-bot
Merge PR #548 into 16.0
a4d511f 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk The merge process could not be finalized, because command /tmp/tmpnmgtdx91/bin/python setup.py bdist_wheel --dist-dir /tmp/tmprf3_h397 --bdist-dir /tmp/tmp9nqyzllh --python-tag py3 failed with output:

error in setup command: /tmp/tmpr_jw73n4/setup/queue_job_subscribe/odoo/addons must contain exactly one installable Odoo addon dir, found []

@ramiadavid
Copy link
Contributor Author

@simahawk can you try again?

@julenfl
Copy link

julenfl commented Sep 19, 2023

@simahawk, can you try the merge again?, thank you very much.

@julenfl
Copy link

julenfl commented Sep 25, 2023

@guewen, can you try the merge again?, thank you very much.

@guewen
Copy link
Member

guewen commented Sep 25, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-548-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f36447b into OCA:16.0 Sep 25, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eb83d6f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amh-mw amh-mw amh-mw approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@kikopeiro kikopeiro kikopeiro approved these changes

@asierneiradev asierneiradev asierneiradev approved these changes

@julenfl julenfl julenfl approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ramiadavid @julenfl @OCA-git-bot @simahawk @guewen @amh-mw @ivantodorovich @kikopeiro @asierneiradev @mymage