[16.0][FIX] base_import_async: restore class #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In migration to 16.0, input class `oe_import_queue` was replaced by another one when it has to be added instead, causing the module not to work. In Javascript, input is searched by this class and it's not found, so value cannot be recovered and import is made synchronously.
danielduqma
changed the title
kikopeiro
approved these changes
Sep 13, 2023
dzungtran89
approved these changes
Sep 13, 2023
|
This PR has the |
|
@gurneyalex could you please take a look? Thanks in advance! |
|
Could you give us a hand? Thank you very much |
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 499fe3b. Thanks a lot for contributing to OCA. ❤️ |
@guewen, many thanks to you for the support and speed, best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In migration to 16.0, input class
oe_import_queuewas replaced by another one when it has to be added instead, causing the module not to work. In Javascript, input is searched by this class and it's not found, so value cannot be recovered and import is made synchronously.This can be reproduced in runboat, trying to import any model and checking Import in the background. Records are imported in foreground.
Migration was made in #523, seems that it was merged without simple functional testing
cc @gurneyalex @dzungtran89