[16.0] Fix multi databases with list_db = false #589
Conversation
…tance with list_db = False The scenario is a multi database environment where you can't set db_name as the databases change frequently and you use dbfilter to allow users to access their DB according to domain
…e with list_db=false
guewen
changed the title
|
thank you so much |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at f86ebbb. Thanks a lot for contributing to OCA. ❤️ |
| """ | ||
| >>> runner = QueueJobRunner() | ||
| >>> config["db_name"] = None | ||
| >>> runner.get_db_names() | ||
| ['odoo'] | ||
| """ |
There was a problem hiding this comment.
What about add list_db = False to test odoo.service.db.list_dbs(True) against odoo.service.db.exp_list(True)?
>>> config["list_db"] = False
There was a problem hiding this comment.
i'm not sure about the implications, as I must confess I never checked what list_dbs or exp_list does
There was a problem hiding this comment.
oh, i finally understood. Yes, thats a great idea, and a much better test approach
This only checks list_dbs gives something like untested exp_lists, your test checks if it works without list_dbs
Port of #379 , #571, #580