Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][FIX] queue_job: fix test cases from TestDelayable being skipped #702

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[18.0][FIX] queue_job: fix test cases from TestDelayable being skipped #702

merged 1 commit into from
Oct 21, 2024

Conversation

thienvh332
Copy link
Contributor

@thienvh332 thienvh332 commented Oct 21, 2024 •
edited
Loading

Issue: Testcases from TestDelayable are being skipped

2024-10-16 05:23:34,643 427499 DEBUG v18c_queue_job odoo.tests.tag_selector: Skipping test 'test_delayable_set (odoo.addons.queue_job.tests.test_delayable.TestDelayable.test_delayable_set)' because no test_tag found. 
2024-10-16 05:23:34,644 427499 DEBUG v18c_queue_job odoo.tests.tag_selector: Skipping test 'test_delayable_set_unknown (odoo.addons.queue_job.tests.test_delayable.TestDelayable.test_delayable_set_unknown)' because no test_tag found. 
2024-10-16 05:23:34,644 427499 DEBUG v18c_queue_job odoo.tests.tag_selector: Skipping test 'test_graph_add_vertex_edge (odoo.addons.queue_job.tests.test_delayable.TestDelayable.test_graph_add_vertex_edge)' because no test_tag found. 
.........

Reason:

  • Testcases from TestDelayable are being skipped because the class is not inheriting from odoo.tests.common.BaseCase. This results in testcases not being assigned test-tags automatically and odoo will skip those testcases.

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@thienvh332 thienvh332 marked this pull request as ready for review October 21, 2024 07:07
This was referenced Oct 21, 2024
Merged
Merged
guewen
guewen approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guewen
Copy link
Member

guewen commented Oct 21, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-702-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eb58253 into OCA:18.0 Oct 21, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eb58253. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guewen guewen guewen approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thienvh332 @OCA-git-bot @guewen