Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] report_xlsx: Migration to 14.0 #443

Merged
merged 32 commits into from
Nov 25, 2020
Merged

[14.0][MIG] report_xlsx: Migration to 14.0 #443

merged 32 commits into from
Nov 25, 2020

Conversation

tupaq
Copy link
Contributor

@tupaq tupaq commented Oct 19, 2020

No description provided.

@tupaq tupaq mentioned this pull request Oct 19, 2020
Closed
@kittiu kittiu mentioned this pull request Oct 20, 2020
Merged
5 tasks
tonygalmiche
tonygalmiche suggested changes Oct 20, 2020
View reviewed changes
Copy link

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same problem :

image

@tupaq
Copy link
Contributor Author

tupaq commented Oct 20, 2020

You may need to update the repository.
In case the problem persists.
Could send the message that appears in the odoo logs.

@tonygalmiche
Copy link

You may need to update the repository.
In case the problem persists.
Could send the message that appears in the odoo logs.

I am doing the test with runbot, I do not see the server logs

@tupaq
Copy link
Contributor Author

tupaq commented Oct 20, 2020

You may need to update the repository.
In case the problem persists.
Could send the message that appears in the odoo logs.

I am doing the test with runbot, I do not see the server logs

Is fixed:
The error is because the field is not defined:
report_file in report_xlsx/demo/report.xml

@tupaq tupaq mentioned this pull request Oct 21, 2020
Closed
2 tasks
tonygalmiche
tonygalmiche approved these changes Oct 21, 2020
View reviewed changes
Copy link

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : Functional review only with runbot

image

@pedrobaeza pedrobaeza mentioned this pull request Oct 24, 2020
Merged
9 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-443-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 2, 2020
@OCA-git-bot
Merge PR #443 into 14.0
ac07aeb 
Signed-off-by LoisRForgeFlow
@LoisRForgeFlow
Copy link
Contributor

Could rebase and run latest pre-commit config? that should fix the error during the merge https://travis-ci.com/github/OCA/reporting-engine/jobs/423958890

@ventor-dev
Copy link

@tupaq , could you, please, rebase as requested by @LoisRForgeFlow so that can be merged?

pedrocs-exo and others added 14 commits November 4, 2020 07:39
@pedrocs-exo @tupaq
Added translation using Weblate (Portuguese)
0fbcfd1
@pedrocs-exo @tupaq
Translated using Weblate (Portuguese)
3b823c5 
Currently translated at 94.4% (17 of 18 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/
@OCA-git-bot @tupaq
report_xlsx 12.0.1.0.1
bfc46ff
@schout-it @tupaq
[MIG] report_xlsx: Migration to 13.0
adb7170
@schout-it @tupaq
[MIG][IMP][13.0] rebase to include new linters
7d48d9a
@JoanSForgeFlow @tupaq
[FIX] report_xlsx: js
b6adb72
@oca-travis @tupaq
[UPD] Update report_xlsx.pot
c35fc4f
@OCA-git-bot @tupaq
[UPD] README.rst
b3ed3e6
@oca-transbot @tupaq
Update translation files
295bdd0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@MiquelRForgeFlow @tupaq
[FIX] report_xlsx: rename a file
73ecc2b
@OCA-git-bot @tupaq
pre-commit update
da836c1
@OCA-git-bot @tupaq
report_xlsx 13.0.1.0.1
60217cd
@oca-transbot @tupaq
Update translation files
66b2968 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-13.0/reporting-engine-13.0-report_xlsx
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xlsx/
@tupaq
[IMP] : black, isort, prettier
155d1e0
@tupaq
Copy link
Contributor Author

tupaq commented Nov 4, 2020

Could rebase and run latest pre-commit config? that should fix the error during the merge https://travis-ci.com/github/OCA/reporting-engine/jobs/423958890

@LoisRForgeFlow is rebased.

@coleste coleste mentioned this pull request Nov 13, 2020
Closed
6 tasks
@ventor-dev
Copy link

@LoisRForgeFlow , could you, please, merge?

@ventor-dev
Copy link

@LoisRForgeFlow , anybody can merge this change?

mamcode
mamcode approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review 👍

@pedrobaeza pedrobaeza added this to the 14.0 milestone Nov 25, 2020
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-443-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1f4a060 into OCA:14.0 Nov 25, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c766008. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart StefanRijnhart mentioned this pull request Feb 10, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonygalmiche tonygalmiche tonygalmiche approved these changes

@mamcode mamcode mamcode approved these changes

@florian-dacosta florian-dacosta florian-dacosta approved these changes

@feketemihai feketemihai feketemihai approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.