Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] report_xlsx_helper #456

Merged
merged 46 commits into from
Dec 2, 2020
Merged

[14.0][MIG] report_xlsx_helper #456

merged 46 commits into from
Dec 2, 2020

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Nov 19, 2020 •
edited
Loading

This module change format to global file

In v14 AbstractModel class can't used self.

Example
self.format_ws_title > it will throw error.
So, I change it to FORMATS["format_ws_title"]

Call function v13 (old)
Selection_002

Call function v14 (new)
from .report_xlsx_format import FORMATS, XLS_HEADERS
Selection_001

WDYT?

cc : @luc-demeyer

luc-demeyer and others added 30 commits November 19, 2020 12:42
@luc-demeyer @Saran440
rename module
b917bcc
@luc-demeyer @Saran440
xlsx formats
2ab4d6d
@luc-demeyer @Saran440
improved error handling
44a0be4
@luc-demeyer @Saran440
autodetect boolean type
b88ed0b
@luc-demeyer @Saran440
pylint: disable=old-api7-method-defined
900bf46
@luc-demeyer @Saran440
pylint: disable=old-api7-method-defined
85c9b1a
@luc-demeyer @Saran440
pylint W8112(eval-referenced)
620af44
@luc-demeyer @Saran440
pylint eval-used
d2f5156
@luc-demeyer @Saran440
add unit test
61adba8
@oca-travis @Saran440
[UPD] Update report_xlsx_helper.pot
f8d3175
@luc-demeyer @Saran440
[11.0][MIG] report_xlsx_helper: Migration to 11.0
bd1765e
@luc-demeyer @Saran440
add todo
95f67d8
@oca-travis @Saran440
[UPD] Update report_xlsx_helper.pot
a77dede
@OCA-git-bot @Saran440
[UPD] README.rst
cf9185d
@luc-demeyer @Saran440
[10.0][FIX]fix _render for cell formats
9d1609a
@luc-demeyer @Saran440
[MIG] : Migration to 12.0
01f9f13
@OCA-git-bot @Saran440
[UPD] README.rst
269488a
@oca-travis @Saran440
[UPD] Update report_xlsx_helper.pot
aa58660
@OCA-git-bot @Saran440
[UPD] README.rst
c18dc74
@luc-demeyer @Saran440
date to datetime conversion when autotyping
77f2e01
@luc-demeyer @Saran440
greenify
db377b7
@luc-demeyer @Saran440
increase test coverage
786071a
@oca-travis @Saran440
[UPD] Update report_xlsx_helper.pot
70634bd
@OCA-git-bot @Saran440
report_xlsx_helper 12.0.1.1.0
fd41726
@ivantodorovich @Saran440
FIX error message when cellvalue's type is not recognized
534e217
@OCA-git-bot @Saran440
report_xlsx_helper 12.0.1.1.1
1aaff5a
@kongrattapong @Saran440
[IMP] report_xlsx_helper: black, isort
f33e647
@kongrattapong @Saran440
[MIG] report_xlsx_helper: Migration to 13.0
24f5984
@oca-travis @Saran440
[UPD] Update report_xlsx_helper.pot
85a6f8d
@OCA-git-bot @Saran440
[UPD] README.rst
989226a
luc-demeyer
luc-demeyer suggested changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@luc-demeyer luc-demeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf. changes suggested in the conversation.

@Saran440
Copy link
Member Author

@luc-demeyer Fixed. Thank you for your reviewed.

  • add grey color in format
  • delete lang context in controller
  • Could you help migrated demo to this PR or new PR?

@luc-demeyer
Copy link
Contributor

@Saran440
Thanks a lot. I'll make a PR on to this PR to add the demo module.

@luc-demeyer
Copy link
Contributor

@Saran440
I have now added the report_xlsx_helper_demo module, can you merge it into this PR ?
Cf. ecosoft-odoo#1

alan196
alan196 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@alan196 alan196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kittiu
kittiu approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@kittiu kittiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tested.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebastienbeau
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-456-by-sebastienbeau-bump-nobump, awaiting test results.

@kittiu kittiu mentioned this pull request Dec 2, 2020
Merged
5 tasks
@OCA-git-bot OCA-git-bot merged commit 6835de4 into OCA:14.0 Dec 2, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 596b168. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart StefanRijnhart mentioned this pull request Feb 10, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittiu kittiu kittiu approved these changes

@alan196 alan196 alan196 approved these changes

@luc-demeyer luc-demeyer luc-demeyer approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Saran440 @luc-demeyer @OCA-git-bot @sebastienbeau @kittiu @alan196 @oca-travis @ivantodorovich @kongrattapong