[MIG] report_py3o: Migration to 15.0 #569

phuctranfxvn · 2021-12-22T04:06:09Z

Standard migration of module report_py3o to support odoo 15
No extra feature added in this migration

nilshamerlinck · 2021-12-22T10:21:29Z

Nice!

I believe the ci/runbot check could be disabled for this branch, right @gurneyalex ?

pedrobaeza · 2022-01-24T14:52:58Z

/ocabot migration report_py3o

BT-dmontull · 2022-04-04T12:56:06Z

@nilshamerlinck @pedrobaeza @gurneyalex
Does anyone know the status of this migration? it seems to be giving error in a check that it is no longer used.
thanks

gurneyalex · 2022-04-04T15:37:41Z

@BT-dmontull I don't know much about the status of this migration apart from "it needs reviews". I'm not currently using this addon so I can't go beyond "the migration looks good to me". If you are asking, possibly this means you plan on using the module: could you then install it on a test instance and check that it works and make a review? This would allow me to merge the PR.

gurneyalex · 2022-04-04T15:37:56Z

@phuctranfxvn can you rebase your PR?

[t128608] add OCA/pull/569

StefanRijnhart · 2022-05-14T08:34:28Z

@phuctranfxvn again, please rebase to resolve conflicts.

… the server

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_py3o/

In v 14.0 time module is already in safe_eval https://github.com/odoo/odoo/blob/14.0/odoo/tools/safe_eval.py#L38 Co-authored-by: mourad-ehm <[email protected]>

Co-authored-by: Alexis de Lattre <[email protected]>

…eport displaying date and time

…d red Co-authored-by: Nils Hamerlinck <[email protected]>

Co-authored-by: Nils Hamerlinck <[email protected]>

phuctranfxvn · 2022-05-15T15:21:34Z

@phuctranfxvn again, please rebase to resolve conflicts.

Hello, sorry for late reply. conflicts resolved.

StefanRijnhart · 2022-05-15T18:15:05Z

report_py3o/views/py3o_template.xml

+    </record>
+    <menuitem
+        id="py3o_template_configuration_menu"
+        parent="py3o_config_menu"


I don't see this template submenu in runboat (as user admin):

The same template menu does appear in the 14.0 runboat of this project:

Do you know why?

I think we should just drop this sub-menu entirely and make Py3o Templates be sub-menu of Reporting, which seems just fine?

Sounds good!

This change is mandatory to can see the Py3o models :/ I clarify that right now it is not possible to access the py3o models from the menu. Too many levels to be able to show itself.

hoangtrann · 2022-10-04T06:42:41Z

I've tested this PR and it works fine, although the js file naming with esm is a bit off from other sources

StefanRijnhart · 2022-10-04T07:14:57Z

I've tested this PR and it works fine, although the js file naming with esm is a bit off from other sources

That's according to the OCA guidelines, for ESLint compatibility.

Thanks for testing! Can you approve the PR on the Files changed tab?

hoangtrann

Tested and work well on my end 👍 Thanks for the contribution

hoangtrann · 2022-10-04T08:30:40Z

report_py3o/views/py3o_template.xml

+    </record>
+    <menuitem
+        id="py3o_template_configuration_menu"
+        parent="py3o_config_menu"


I suggest dropping the sub-menu and we should be good to go

Suggested change

parent="py3o_config_menu"

parent="base.reporting_menuitem"

github-actions · 2023-02-05T12:25:48Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Tardo · 2023-03-17T09:59:41Z

ping @phuctranfxvn

Tardo · 2023-03-24T12:05:18Z

I go to supersede this PR.

phuctranfxvn mentioned this pull request Dec 22, 2021

Migration to version 15.0 #545

Closed

20 tasks

phuctranfxvn force-pushed the 15.0-mig-report_py3o branch 3 times, most recently from 088b581 to a97c409 Compare December 22, 2021 05:19

OCA-git-bot added this to the 15.0 milestone Jan 24, 2022

phuctranfxvn force-pushed the 15.0-mig-report_py3o branch 2 times, most recently from 59d613d to 2e0aedf Compare February 1, 2022 14:30

gurneyalex approved these changes Apr 4, 2022

View reviewed changes

BT-dmontull added a commit to brain-tec/reporting-engine that referenced this pull request Apr 7, 2022

Merge pull request #368 from brain-tec/15.0.project_SY_639.t128608

3840e22

[t128608] add OCA/pull/569

lmignon and others added 15 commits May 15, 2022 22:01

Move to report_py3o after import from HG

29e0567

Add setup

3d1d8bd

[FIX] View inheritance may not use attribute 'string' as a selector.

b4452cd

[IMP] New API + Short Hearder

826e6df

Remove unicode string

8b4a80d

[IMP] Add the possiblity to get the template from an absolute path on…

bd34c3e

… the server

[IMP] Allow user to use local fusion

30a9d3d

Add a simple way to extend the parser context

5d6d9b7

Remove ACL on removed model

78c57d5

Improve filetype selection name

dc9d908

Fix native flag

2a68632

fixed missing comma in model definition

8465ce7

Add simple tests and fix call to fusion server

35b75a2

Fix skip fusion on server when the fusion is local

30c7aab

Improve tests

921cf9f

sbidoul and others added 17 commits May 15, 2022 22:01

[FIX] make prettier happy

05ea64b

[UPD] Update report_py3o.pot

51ba2fa

[UPD] README.rst

13c0b88

Update translation files

b4b49b7

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_py3o/

Update translation files

9156d51

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_py3o/

[14.0][MIG] report_py3o: Migration to 14.0

712770e

Update report_py3o/models/ir_actions_report.py

6392b89

In v 14.0 time module is already in safe_eval https://github.com/odoo/odoo/blob/14.0/odoo/tools/safe_eval.py#L38 Co-authored-by: mourad-ehm <[email protected]>

[MIG] Use safe_eval wrapped time module. Fix deprecation warnings.

4b619b8

Co-authored-by: Alexis de Lattre <[email protected]>

[IMP] Add ability to include properly formatted datetime field in a r…

e770589

…eport displaying date and time

[IMP] Workaround for genshi DeprecationWarning that makes runbot buil…

6720eda

…d red Co-authored-by: Nils Hamerlinck <[email protected]>

[IMP] Cleanup unnecessary imports

2fa3c16

Co-authored-by: Nils Hamerlinck <[email protected]>

[IMP] Remove except of IOError as its an alias to OSError in python3

306a4aa

Co-authored-by: Nils Hamerlinck <[email protected]>

run pre-commit

dad197c

[UPD] Update report_py3o.pot

b52cacb

[UPD] README.rst

c170531

[IMP] report_py3o: black, isort, prettier

1bbe5ed

[MIG] report_py3o: Migration to 15.0

5e54d49

phuctranfxvn force-pushed the 15.0-mig-report_py3o branch from 12edc1e to 5e54d49 Compare May 15, 2022 15:20

StefanRijnhart reviewed May 15, 2022

View reviewed changes

hoangtrann approved these changes Oct 4, 2022

View reviewed changes

OCA-git-bot added the approved label Oct 4, 2022

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 5, 2023

github-actions bot closed this Mar 12, 2023

Tardo mentioned this pull request Mar 24, 2023

[15.0][MIG] report_py3o #744

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] report_py3o: Migration to 15.0 #569

[MIG] report_py3o: Migration to 15.0 #569

phuctranfxvn commented Dec 22, 2021

nilshamerlinck commented Dec 22, 2021

pedrobaeza commented Jan 24, 2022

BT-dmontull commented Apr 4, 2022

gurneyalex commented Apr 4, 2022

gurneyalex commented Apr 4, 2022

StefanRijnhart commented May 14, 2022

phuctranfxvn commented May 15, 2022

StefanRijnhart May 15, 2022

hoangtrann Oct 4, 2022

StefanRijnhart Oct 4, 2022

Tardo Feb 8, 2023 •

edited

Loading

hoangtrann commented Oct 4, 2022

StefanRijnhart commented Oct 4, 2022 •

edited

Loading

hoangtrann left a comment

hoangtrann Oct 4, 2022

github-actions bot commented Feb 5, 2023

Tardo commented Mar 17, 2023

Tardo commented Mar 24, 2023

[MIG] report_py3o: Migration to 15.0 #569

[MIG] report_py3o: Migration to 15.0 #569

Conversation

phuctranfxvn commented Dec 22, 2021

nilshamerlinck commented Dec 22, 2021

pedrobaeza commented Jan 24, 2022

BT-dmontull commented Apr 4, 2022

gurneyalex commented Apr 4, 2022

gurneyalex commented Apr 4, 2022

StefanRijnhart commented May 14, 2022

phuctranfxvn commented May 15, 2022

StefanRijnhart May 15, 2022

Choose a reason for hiding this comment

hoangtrann Oct 4, 2022

Choose a reason for hiding this comment

StefanRijnhart Oct 4, 2022

Choose a reason for hiding this comment

Tardo Feb 8, 2023 • edited Loading

Choose a reason for hiding this comment

hoangtrann commented Oct 4, 2022

StefanRijnhart commented Oct 4, 2022 • edited Loading

hoangtrann left a comment

Choose a reason for hiding this comment

hoangtrann Oct 4, 2022

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2023

Tardo commented Mar 17, 2023

Tardo commented Mar 24, 2023

Tardo Feb 8, 2023 •

edited

Loading

StefanRijnhart commented Oct 4, 2022 •

edited

Loading