[15.0][MIG] base_comment_template: Migration to 15.0 #646

victoralmau · 2022-09-02T06:53:34Z

Superseed: #619

Migration to 15.0

Please @pedrobaeza and @CarlosRoca13 can you review it?

@Tecnativa TT35696

pedrobaeza · 2022-09-02T07:46:12Z

/ocabot migrationbase_comment_template

OCA-git-bot · 2022-09-02T07:46:16Z

Hi @pedrobaeza. Your command failed:

Invalid command: migrationbase_comment_template.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase* ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

pedrobaeza · 2022-09-02T07:47:04Z

/ocabot migration base_comment_template

pedrobaeza

Please add a commit on top of the previous one with your changes instead of blending them with the existing.

pedrobaeza · 2022-09-02T07:49:43Z

base_comment_template/wizard/base_comment_template_preview_views.xml

-                    </p>
-                    <label for="body" string="Base Comment content" />
-                    <hr />
+    <!-- SMS Template Preview -->


This has no sense

pedrobaeza · 2022-09-02T07:49:46Z

base_comment_template/wizard/base_comment_template_preview.py

        string="Template Preview Engine",
-        default="jinja",
+        default="inline_template",


A migration script is needed to convert existing values to this new one.

hailangvn

Functional test ok. Thanks for the work.

marylla · 2022-09-13T07:23:58Z

@victoralmau Can you please update your PR as Pedro suggested. Thank you! :)

Port modules base_comment_template and invoice_comment_template to V10

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/gl/ [ADD] icon.png

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/ja/

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt/

Currently translated at 100.0% (15 of 15 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_BR/

[IMP] Move comment_template_id from account_invoice_comment_template and make it company_dependant [IMP] base_comment_template: Add test

…d to the Invoicing tab [IMP] account_invoice_comment_template: rename partner field name from comment_template_id to invoice_comment_template_id [IMP] account_invoice_comment_template: Make partner field company_dependant and move domain definition of invoice fields from the view to the model [MOV] account_invoice_comment_template: comment_template_id to base_comment_template [IMP] account_invoice_comment_template: Translate templates when partner changes

[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_BR/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt/

Currently translated at 95.2% (20 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/hr/

Previous field declaration was incorrect due to a typo, leading to non applying the company dependent features. Now everything is correct and the migration scripts care of moving data properly.

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/de/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/pt_PT/

Currently translated at 100.0% (21 of 21 strings) Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/sk/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoice-reporting-12.0/account-invoice-reporting-12.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-12-0/account-invoice-reporting-12-0-base_comment_template/

As the field was not properly converted to property at 2.0.0, the script fails to do its job when migrating from v11, so we need to adapt the scripts to this situation.

…oid FK constraint - The name of the columns were swapped, so better to fix it for avoiding mistakes due to this. - Migration script for detecting the condition and swap column names. - On v12 > v13 migration, include JOINs for avoiding FK constraint, which `ON CONFLICT` clause doesn't protect.

[UPD] Update base_comment_template.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/

1. Safe eval domain before checking if it is defined. This makes [] be "False" on the first check, and provides the proper use case for when the domain is empty 2. Use filtered_domain in record instead of a search in self. When on a compute, we are on a NewId context, so the search would always fail TT29309

base_comment_template 14.0.2.0.1

Currently translated at 100.0% (36 of 36 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/pt/

Currently translated at 100.0% (36 of 36 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/it/

[UPD] Update base_comment_template.pot [UPD] README.rst base_comment_template 14.0.3.0.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-14.0/reporting-engine-14.0-base_comment_template Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-base_comment_template/

base_comment_template 14.0.3.0.1

TT35696

victoralmau · 2022-09-13T15:21:48Z

The commits are already separated and I have added the migration script to convert the text of templates.

marylla · 2022-09-15T07:55:08Z

@pedrobaeza Can you review again please?

pedrobaeza

Missed jinja to inline_template value mapping

victoralmau · 2022-09-16T06:41:07Z

Missed jinja to inline_template value mapping

Sorry, I don't understand exactly what you mean.

The engine change from jinja to inline_template is only used in wizard to rendering the comment.

pedrobaeza

OK, seen

pedrobaeza · 2022-09-16T06:44:59Z

/ocabot merge nobump

OCA-git-bot · 2022-09-16T07:44:01Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-646-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-09-16T07:45:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2022-09-16T07:50:19Z

Congratulations, your PR was merged at a3dbd50. Thanks a lot for contributing to OCA. ❤️

victoralmau mentioned this pull request Sep 2, 2022

[15.0] Migration of base_comment_template #619

Closed

9 tasks

OCA-git-bot added this to the 15.0 milestone Sep 2, 2022

OCA-git-bot mentioned this pull request Sep 2, 2022

Migration to version 15.0 #545

Closed

20 tasks

pedrobaeza requested changes Sep 2, 2022

View reviewed changes

hailangvn approved these changes Sep 10, 2022

View reviewed changes

guewen and others added 21 commits September 13, 2022 16:29

Rename base_condition_template to base_comment_template

4dd0f9d

[MIG] base_comment_template to 9.0

6faca5e

[MIG] base_comment_template, invoice_comment_template: Migration to 10.0

627ef24

Port modules base_comment_template and invoice_comment_template to V10

[MIG] base_comment_template: Migration to 11.0

c7cc022

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[MIG] base_comment_template: Migration to 12.0

f946198

[IMP] base_comment_template multi company rules

1f665aa

[IMP] Move comment_template_id from account_invoice_comment_template and make it company_dependant [IMP] base_comment_template: Add test

[FIX] base_comment_template: Make field truly company dependent

78d335f

Previous field declaration was incorrect due to a typo, leading to non applying the company dependent features. Now everything is correct and the migration scripts care of moving data properly.

[FIX] base_comment_template: Make field truly company dependent

04826fb

Previous field declaration was incorrect due to a typo, leading to non applying the company dependent features. Now everything is correct and the migration scripts care of moving data properly.

[MIG+FIX] base_comment_template: Fix migration scripts

f43d655

As the field was not properly converted to property at 2.0.0, the script fails to do its job when migrating from v11, so we need to adapt the scripts to this situation.

victoralmau and others added 14 commits September 13, 2022 16:44

[FIX] base_comment_template: Fix tests: test_company_general_template

f66698a

[FIX] base_comment_template: Change domain in rule according to company

ce15465

[IMP] base_comment_template: Refactor code and convert to Many2Many

c646ae8

[FIX] base_comment_template: Delete res_partner.xml view (not used now)

8c2f189

base_comment_template 14.0.2.0.1

[FIX] base_comment_template: Typo error

a50df16

base_comment_template 14.0.3.0.1

[IMP] base_comment_template: black, isort, prettier

a348edf

[MIG] base_comment_template: Migration to 15.0

3b50a7a

[MIG] base_comment_template: Migration to 15.0

13b6017

TT35696

victoralmau force-pushed the 15.0-mig-base_comment_template branch from 6600caa to 13b6017 Compare September 13, 2022 15:19

pedrobaeza reviewed Sep 15, 2022

View reviewed changes

pedrobaeza approved these changes Sep 16, 2022

View reviewed changes

OCA-git-bot added the approved label Sep 16, 2022

OCA-git-bot added bot is merging ⏳ ready to merge labels Sep 16, 2022

OCA-git-bot merged commit 9ecc402 into OCA:15.0 Sep 16, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] base_comment_template: Migration to 15.0 #646

[15.0][MIG] base_comment_template: Migration to 15.0 #646

victoralmau commented Sep 2, 2022

pedrobaeza commented Sep 2, 2022

OCA-git-bot commented Sep 2, 2022

pedrobaeza commented Sep 2, 2022

pedrobaeza left a comment

pedrobaeza Sep 2, 2022

pedrobaeza Sep 2, 2022

hailangvn left a comment

marylla commented Sep 13, 2022

victoralmau commented Sep 13, 2022

marylla commented Sep 15, 2022

pedrobaeza left a comment

victoralmau commented Sep 16, 2022

pedrobaeza left a comment

pedrobaeza commented Sep 16, 2022

OCA-git-bot commented Sep 16, 2022

OCA-git-bot commented Sep 16, 2022

OCA-git-bot commented Sep 16, 2022

[15.0][MIG] base_comment_template: Migration to 15.0 #646

[15.0][MIG] base_comment_template: Migration to 15.0 #646

Conversation

victoralmau commented Sep 2, 2022

pedrobaeza commented Sep 2, 2022

OCA-git-bot commented Sep 2, 2022

pedrobaeza commented Sep 2, 2022

pedrobaeza left a comment

Choose a reason for hiding this comment

pedrobaeza Sep 2, 2022

Choose a reason for hiding this comment

pedrobaeza Sep 2, 2022

Choose a reason for hiding this comment

hailangvn left a comment

Choose a reason for hiding this comment

marylla commented Sep 13, 2022

victoralmau commented Sep 13, 2022

marylla commented Sep 15, 2022

pedrobaeza left a comment

Choose a reason for hiding this comment

victoralmau commented Sep 16, 2022

pedrobaeza left a comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 16, 2022

OCA-git-bot commented Sep 16, 2022

OCA-git-bot commented Sep 16, 2022

OCA-git-bot commented Sep 16, 2022