-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] Allow endpoint with slash in root path #344
Conversation
Hi @lmignon, |
88c6869
to
694a0e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flachica IMO it's a bad idea since /
as Root path
could lead to collision with Odoo's routes. Your app should always have its specific root path as mount point into the Odoo server. I should enforce this rule on the fastapi.endpoint
model.
@lmignon First of all, thank you very much for your time. Currently it would only be possible to define "/app". With the proposed change the rest of the values would be allowed. |
@flachica OK I understand now your point. The problem is wider. How can we deal with subpath into the root path at the same time of subpath in route? A route could also be declared as 'sales/items/'. I've to thing a little bit further to implement the right logic and support subpath for apps and routes. |
5974528
to
eca9d14
Compare
eca9d14
to
839d89b
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@lmignon can you elaborate a bit on the issues you foresee? I haven't tried yet tho. Also, depending on the use case you can use |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
If I define a endpoint with slash in
Root path
this is not found and throw an 404 error