-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] product_sold_by_delivery_week: Migration to 15.0 #159
[15.0][MIG] product_sold_by_delivery_week: Migration to 15.0 #159
Conversation
@pedrobaeza please review |
@carlosdauden please review |
/ocabot migration product_sold_by_delivery_week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no unit tests, so it's difficult to know if everything goes right.
3ea0e47
to
532e94c
Compare
Added three tests |
490d487
to
e3a6ee9
Compare
@LudLaf could you review this? |
@LudLaf instead of editing from GitHub interface, you have to do it on your local and commit only once following commit message guidelines. |
757028d
to
f3a564d
Compare
f3a564d
to
acedda8
Compare
Changes now made in local and pushed from there. |
acedda8
to
661ba40
Compare
All the commits are correctly done now. |
661ba40
to
53fd708
Compare
53fd708
to
fb8e9f7
Compare
@LudLaf could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there's still a lot of untested code.
|
||
- For the sold char: `product_sold_by_delivery_week.sold_char` | ||
- For the not sold: `product_sold_by_delivery_week.not_sold_char` | ||
- For weeks length: `product_sold_by_delivery_week.weeks_to_consider` | ||
- For weeks length: `product_sold_by_delivery_week.weeks_to_consider` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect extra indentation level. This goes in the first indentation.
def setUpClass(cls): | ||
super().setUpClass() | ||
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty lines inside a method.
super().setUpClass() | ||
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) | ||
|
||
cls.partner = cls.env.ref("base.res_partner_12") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use demo data.
""" | ||
Test a SO with a product on delivery. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
Test a SO with a product on delivery. | |
""" | |
"""Test a SO with a product on delivery.""" |
ping @chienandalu |
@cesar-tecnativa Could you attend @pedrobaeza comments? |
César is no longer working on Odoo world, so another person will attend it. |
a141777
to
613fb3e
Compare
@pedrobaeza Changes done!!! |
613fb3e
to
6eda7ac
Compare
We should supersede and add changes on #176 |
I will add the commits when this PR #196 will be marged to fix the CI too |
…g data instead use dot notation. Add security groups to avoid unnecessary compute. TT32983
…partners_for_reporting TT39913
6eda7ac
to
072689b
Compare
…n dict TT40635 TT40642
072689b
to
2d84c2c
Compare
Done @carlosdauden |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at d766ec8. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT36501