[17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253

jeroenev · 2024-02-21T16:00:23Z

No description provided.

Hide details for sections in sales orders and invoices for reports and customer portal

Currently translated at 100.0% (7 of 7 strings) Translation: sale-reporting-11.0/sale-reporting-11.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-11-0/sale-reporting-11-0-sale_layout_category_hide_detail/es/

…nvoice" Propagate values in 'Show details' and 'Show subtotal' fields from Sale Order Lines to Invoice Lines

… tests + linting + JS for column not in fieldsInfo list

If a note line is put in first position, we get an error due to this missing condition. [UPD] Update sale_layout_category_hide_detail.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-reporting-13.0/sale-reporting-13.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-13-0/sale-reporting-13-0-sale_layout_category_hide_detail/ [UPD] README.rst

Currently translated at 100.0% (11 of 11 strings) Translation: sale-reporting-13.0/sale-reporting-13.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-13-0/sale-reporting-13-0-sale_layout_category_hide_detail/es/

Add a third clickable option on sections to hide all amounts in the detailed lines of a section. [UPD] Update sale_layout_category_hide_detail.pot sale_layout_category_hide_detail 13.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-reporting-13.0/sale-reporting-13.0-sale_layout_category_hide_detail Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-13-0/sale-reporting-13-0-sale_layout_category_hide_detail/

… section line subtotal

…nt working

…shed invoices or confirmed orders. Related to: OCA#128 (comment) TT38579

…olumns of the buttons so that the table takes up as little space as possible. TT38579

… allow inheritability. TT38579

…ons in readme.

…o be sure boolean_fa_icon work fine in all use cases TT38579

…on subtotal' button details and add images to visualize each buttons effects

Change the fa icon Widget to new owl Component

navarrorico

Tested on runboat. The icon buttons of the section are not working.

jeroenev · 2024-03-04T12:46:54Z

Did you test on a Quote or confirmed SO? buttons are only clickable when the quote is not yet confirmed.
This was the same in Odoo16, but I know this was not the case in Odoo14, which might cause some confusion if you know the module from an older Odoo version.
Work correctly on this quote: http://oca-sale-reporting-17-0-pr253-e9ff0b161700.runboat.odoo-community.org/web#id=3&cids=1&menu_id=183&action=313&model=sale.order&view_type=form

navarrorico

@jeroenev True!!! Sorry. All wroks fine then. Thank you

Functional review LGTM 👍

pedrobaeza · 2024-03-04T19:51:42Z

/ocabot migration sale_layout_category_hide_detail

willievmobile · 2024-04-20T14:23:33Z

@jeroenev ive really tried for weeks i cannot get this to work on a odoo17 thats been updated to the version starting this month..?
Im desperately needing this to work for the company so we can use odoo17 as without this we have to make 2 quotes for every job. please help?

Ricardoalso · 2024-06-11T12:51:41Z

@jeroenev ive really tried for weeks i cannot get this to work on a odoo17 thats been updated to the version starting this month..? Im desperately needing this to work for the company so we can use odoo17 as without this we have to make 2 quotes for every job. please help?

Hello @willievmobile, can you give me more context please ?

willievmobile · 2024-06-11T13:03:08Z

@jeroenev I gave up on this issue and just installed odoo 16 and we are working on that.
But basically it looked like it was how the server from Cloudclusters was installed or something. but i just dont know enough to figure it out.

trisdoan · 2024-06-12T02:40:17Z

@jeroenev I gave up on this issue and just installed odoo 16 and we are working on that. But basically it looked like it was how the server from Cloudclusters was installed or something. but i just dont know enough to figure it out.

Hello @willievmobile, I guess the issue you encountered is 500 Internal Server Error

If yes, I prepared an PR to fix it in jeroenev#1. Hello @jeroenev, could you plz take this fix into account?

jeroenev · 2024-06-13T13:27:53Z

@trisdoan any instructions how I would integrate that PR into mine? Not too well versed in the OCA workflows for that

trisdoan · 2024-06-14T02:31:31Z

Hello @jeroenev, you can go to my PR and merge like this

jeroenev · 2024-06-14T07:36:21Z

OK that was easier than expected, thanks a lot!

victoralmau · 2024-06-25T15:17:19Z

Please, cherry-pick #276 to commit history (before migration commit)

OCA-git-bot · 2024-06-25T15:24:54Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

arianzaghi · 2024-07-04T06:57:12Z

@jeroenev Hi! How long is left before the merge?

yvaucher · 2024-08-08T12:16:12Z

As the PR is ready, we can tackle the FW port of #276 in a later PR.

yvaucher · 2024-08-08T12:16:23Z

/ocabot merge nobump

OCA-git-bot · 2024-08-08T12:16:37Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-253-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-08T12:21:19Z

Congratulations, your PR was merged at 339dfec. Thanks a lot for contributing to OCA. ❤️

ernestotejeda and others added 30 commits February 21, 2024 16:56

sale_layout_category_hide_detail: New module

68e43fe

Hide details for sections in sales orders and invoices for reports and customer portal

[MIG] sale_layout_category_hide_detail: Migration to 12.0

6c9e71a

[MIG] sale_layout_category_hide_detail: Migration scripts

3017bc1

[IMP] sale_layout_category_hide_detail: black, isort

3bc22d4

[MIG] sale_layout_category_hide_detail: Migration to 13.0

d6360d0

[FIX] sale_layout_category_hide_detail: Propagate 'Show details' to i…

ef26903

…nvoice" Propagate values in 'Show details' and 'Show subtotal' fields from Sale Order Lines to Invoice Lines

[FIX] sale_layout_category_hide_detail: Column rendering in section +…

1857190

… tests + linting + JS for column not in fieldsInfo list

Apply pre-commit

ff67a90

[IMP] sale_layout_category_hide_detail: black, isort, prettier

20eaa5b

[14.0][MIG] sale_layout_category_hide_detail

4f05e85

[14.0][IMP] sale_layout_category_hide_detail: Add possibility to hide…

c0119d0

… section line subtotal

[14.0][FIX] sale_layout_category_hide_detail: Make the hide line amou…

904c41d

…nt working

[FIX] sale_layout_category_hide_detail: Do not allow changes to publi…

25e84f6

…shed invoices or confirmed orders. Related to: OCA#128 (comment) TT38579

[IMP] sale_layout_category_hide_detail: Apply a custom width to the c…

041f213

…olumns of the buttons so that the table takes up as little space as possible. TT38579

[IMP] sale_layout_category_hide_detail: Simplify code in functions to…

4a0bccd

… allow inheritability. TT38579

[FIX] sale_layout_category_hide_detail: Set the correct URL of the ic…

428c6b7

…ons in readme.

sale_layout_category_hide_detail 14.0.1.0.1

9e02141

[FIX] sale_layout_category_hide_detail: Remove unused code.

b22886d

sale_layout_category_hide_detail 14.0.1.0.2

9b42eae

[FIX] sale_layout_category_hide_detail: Add fields to line_ids tree t…

2b413ad

…o be sure boolean_fa_icon work fine in all use cases TT38579

[IMP] sale_layout_category_hide_detail: black, isort, prettier

a63e247

[MIG] sale_layout_category_hide_detail: Migration to 15.0

2d4226c

[IMP] sale_layout_category_hide_detail: Update readme for 'hide secti…

abb4cc2

…on subtotal' button details and add images to visualize each buttons effects

[MIG] sale_layout_category_hide_detail: Migration to 16.0

5e216f7

Change the fa icon Widget to new owl Component

[UPD] Update sale_layout_category_hide_detail.pot

00f56e3

[UPD] README.rst

44280f0

navarrorico suggested changes Mar 4, 2024

View reviewed changes

navarrorico approved these changes Mar 4, 2024

View reviewed changes

pedrobaeza changed the title ~~17.0 mig sale layout category hide detail~~ [17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 Mar 4, 2024

OCA-git-bot added this to the 17.0 milestone Mar 4, 2024

leemannd approved these changes Jun 13, 2024

View reviewed changes

OCA-git-bot added the approved label Jun 13, 2024

[FIX] error after changes by Odoo

d58f989

jeroenev force-pushed the 17.0-mig-sale_layout_category_hide_detail branch from d695328 to d58f989 Compare June 13, 2024 13:26

[FIX] sale_layout_category_hide_detail: fix bug cannot show sale report

9e8b50e

OCA-git-bot added the ready to merge label Jun 25, 2024

OCA-git-bot added the bot is merging ⏳ label Aug 8, 2024

OCA-git-bot merged commit fc730b2 into OCA:17.0 Aug 8, 2024
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253

[17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253

jeroenev commented Feb 21, 2024

navarrorico left a comment

jeroenev commented Mar 4, 2024 •

edited

Loading

navarrorico left a comment

pedrobaeza commented Mar 4, 2024

willievmobile commented Apr 20, 2024

Ricardoalso commented Jun 11, 2024 •

edited

Loading

willievmobile commented Jun 11, 2024

trisdoan commented Jun 12, 2024

jeroenev commented Jun 13, 2024 •

edited

Loading

trisdoan commented Jun 14, 2024

jeroenev commented Jun 14, 2024

victoralmau commented Jun 25, 2024

OCA-git-bot commented Jun 25, 2024

arianzaghi commented Jul 4, 2024

yvaucher commented Aug 8, 2024

yvaucher commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

[17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253

[17.0][MIG] sale_layout_category_hide_detail: Migration to 17.0 #253

Conversation

jeroenev commented Feb 21, 2024

navarrorico left a comment

Choose a reason for hiding this comment

jeroenev commented Mar 4, 2024 • edited Loading

navarrorico left a comment

Choose a reason for hiding this comment

pedrobaeza commented Mar 4, 2024

willievmobile commented Apr 20, 2024

Ricardoalso commented Jun 11, 2024 • edited Loading

willievmobile commented Jun 11, 2024

trisdoan commented Jun 12, 2024

jeroenev commented Jun 13, 2024 • edited Loading

trisdoan commented Jun 14, 2024

jeroenev commented Jun 14, 2024

victoralmau commented Jun 25, 2024

OCA-git-bot commented Jun 25, 2024

arianzaghi commented Jul 4, 2024

yvaucher commented Aug 8, 2024

yvaucher commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

jeroenev commented Mar 4, 2024 •

edited

Loading

Ricardoalso commented Jun 11, 2024 •

edited

Loading

jeroenev commented Jun 13, 2024 •

edited

Loading