Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_multicompany_reporting_currency: Migration to 16.0 #262

Closed

Conversation

vvrossem
Copy link

@vvrossem vvrossem commented Apr 15, 2024

Depends on #261

@vvrossem vvrossem force-pushed the 16.0-mig-sale_multicompany_reporting_currency branch from a489856 to 5e1972c Compare April 15, 2024 14:06
@yankinmax
Copy link

For OCA PRs depending on another PR: the recommended way is to use test-requirements.txt.
There you can specify your python dependency as:
odoo${10|11|12|13|14}-addon-${addon_name} @ git+https://github.com/OCA/$repo_name@refs/pull/$PR_NR/head#subdirectory=setup/$addon_name
For this to work, you MUST have setup folder updated in the base PR.
Normally this is done on pre-commit run on recent versions BUT it works only when the module is installable. Hence, if you are migrating a module, make sure the setup folder is up to date and staged in the changes.
If you want to generate it manually, just run setuptools-odoo-make-default -d . in the repo folder.
Note that from odoo 15 we don't need the version in the python pkg name anymore.
When you use such approach, always add or update test-requirements.txt in a separated commit to make prominent that there's a commit to trash before merging.

strating from v17
odoo-addon-${addon_name} @ git+https://github.com/OCA/$repo_name.git@refs/pull/$PR_NR/head#subdirectory=${addon_name}

@@ -1 +1 @@
odoo-addon-base_multicompany_reporting_currency @ git+https://github.com/OCA/sale-reporting.git@refs/pull/261/head#subdirectory=base_multicompany_reporting_currency
odoo16-addon-base_multicompany_reporting_currency @ git+https://github.com/OCA/sale-reporting.git@refs/pull/261/head#subdirectory=base_multicompany_reporting_currency
Copy link

@yankinmax yankinmax Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
odoo16-addon-base_multicompany_reporting_currency @ git+https://github.com/OCA/sale-reporting.git@refs/pull/261/head#subdirectory=base_multicompany_reporting_currency
odoo-addon-base_multicompany_reporting_currency @ git+https://github.com/OCA/sale-reporting@refs/pull/261/head#subdirectory=setup/base_multicompany_reporting_currency

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if doesn't work for you try this

@vvrossem vvrossem force-pushed the 16.0-mig-sale_multicompany_reporting_currency branch from bc6aeb3 to a9b9ac0 Compare April 15, 2024 15:56
@vvrossem vvrossem force-pushed the 16.0-mig-sale_multicompany_reporting_currency branch from a9b9ac0 to 9eb9ca4 Compare April 23, 2024 12:56
Ensure `multicompany_reporting_currency_id` is recomputed when changing the `amount_option` value.
@vvrossem vvrossem force-pushed the 16.0-mig-sale_multicompany_reporting_currency branch from 9eb9ca4 to 1dc3b91 Compare April 23, 2024 12:59
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
@github-actions github-actions bot closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants