[17.0][MIG] sale_order_line_position: Migration to 17.0 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module adds an auto computed position on sale order line. This position number is added on the report. The position can be used to keep track of each line during the delivery, invoicing of the order with the customer. This is why there is related modules on `account-invoice-reporting` and `stock-logisics-reporting`. The position set on a line is not changed when the order is not in draft anymore.
The previous implementation with the onchange was broken and hardly feasible (onchange are called on each line and the sequence set on them changes on each call) and not possible to cover with unit tests (reproduce the drag and drop). The other solution could have been to replace the onchange with a recompute of the position on every `write` of a sale.order but that also leads to a complex solution. As the positions are needed to discuss with the customer, the recompute of the position on print, send and confirm is a good enough, simple solution.
Currently translated at 81.8% (9 of 11 strings) Translation: sale-reporting-14.0/sale-reporting-14.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-14-0/sale-reporting-14-0-sale_order_line_position/de/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-reporting-15.0/sale-reporting-15.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-15-0/sale-reporting-15-0-sale_order_line_position/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-reporting-15.0/sale-reporting-15.0-sale_order_line_position Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-15-0/sale-reporting-15-0-sale_order_line_position/
gurneyalex
approved these changes
Apr 25, 2024
|
/ocabot migration sale_order_line_position |
angelmoya
approved these changes
May 6, 2024
|
|
||
| def recompute_positions(self): | ||
| for sale in self: | ||
| if sale.locked_positions or sale.company_id.disable_sale_position_recompute: |
There was a problem hiding this comment.
maybe could be better with filtered in for
| } | ||
| sale_pos = {**default_pos, **existing_pos} | ||
| for line in vals_list: | ||
| if not line.get("display_type"): |
There was a problem hiding this comment.
same comment, better with filtered
|
This PR has the |
mmequignon
approved these changes
May 15, 2024
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 57a89f8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.