Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] sale_layout_category_hide_detail: Full width to note lines #268

Merged
merged 1 commit into from
May 17, 2024
Merged

[14.0][FIX] sale_layout_category_hide_detail: Full width to note lines #268

merged 1 commit into from
May 17, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented May 15, 2024 •
edited
Loading

Note type lines do not need to add any logic, they need to maintain full width.

Before
antes

After
despues

Please @pedrobaeza and @CarlosRoca13 can you review it?

@Tecnativa TT49131

@pedrobaeza pedrobaeza added this to the 14.0 milestone May 15, 2024
@pedrobaeza
Copy link
Member

renderBodyCell is not saying anything. Can you please explain a bit more in the commit message the goal? And doing this is overloading each render with one extra RPC. You should do it on JS on my opinion depending on the display_type.

@victoralmau
[FIX] sale_layout_category_hide_detail: Full width to note lines
731b4b6 
Note type lines do not need to add any logic, they need to maintain full width

TT49131
@victoralmau victoralmau force-pushed the 14.0-imp-sale_layout_category_hide_detail-TT49131 branch from 7c10fe1 to 731b4b6 Compare May 15, 2024 10:39
@victoralmau victoralmau changed the title [14.0][IMP] sale_layout_category_hide_detail: Add function to allow renderBodyCell [14.0][FIX] sale_layout_category_hide_detail: Full width to note lines May 15, 2024
@victoralmau
Copy link
Member Author

Changed to another approach (updated commit description with before and after examples).

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-268-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8249d3c into OCA:14.0 May 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a4e989a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 14.0-imp-sale_layout_category_hide_detail-TT49131 branch May 17, 2024 08:23
@victoralmau victoralmau mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @chienandalu