[15.0][FIX] vault, vault_share: Error on test #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes introduced on odoo/odoo@a251b14#diff-99de14b6e0a411718ac3adaaf779395155841c7ca9d95fa258369656dae63d18 the tests of vault and vault_share are failing.
CarlosRoca13
changed the title
|
BTW... Why are we using server-auth/vault/__manifest__.py Line 13 in 4e970c0 |
fkantelberg
approved these changes
Jun 26, 2023
|
What a great day to merge this nice PR. Let's do it! |
|
@CarlosRoca13 Well yes there is no real dependency to website and I have not found a better way to mock it without copying the function nearly 1:1. Either way adding the dependency wouldn't be my favorite way. Suggestions are welcome |
|
Congratulations, your PR was merged at 292febe. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes introduced on odoo/odoo@a251b14#diff-99de14b6e0a411718ac3adaaf779395155841c7ca9d95fa258369656dae63d18 the tests of vault and vault_share are failing.
cc @Tecnativa
@fkantelberg please, can you review this. I'm not sure if this solution is the correct one, but we need to solve this.
Sorry for the inconvenience