[IMP] make posible to call the onchange on an existing record and avoid returning computed value #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id returning computed value
acsonefho
approved these changes
Jun 11, 2018
lmignon
reviewed
Jun 11, 2018
onchange_helper/models/ir_rule.py
Outdated
| # If self is a record (play onchange on existing record) | ||
| # we take the value of the field | ||
| # If self is an empty record we will have an empty value | ||
| all_values[field] = self[field] |
There was a problem hiding this comment.
you should use convert to write to transform the record's properties into the format expected by 'new'
sebastienbeau
force-pushed
the
10.0-improve-onchange-helper
branch
2 times, most recently
from
0fc85bb
to
bc7e474
Compare
… test and make improve play_onchange
sebastienbeau
force-pushed
the
10.0-improve-onchange-helper
branch
from
bc7e474
to
7e5db10
Compare
…check that record have been not modify
lmignon
reviewed
Jun 12, 2018
onchange_helper/README.rst
Outdated
|
|
||
| Then the onchange will be played with the vals passed and the existing vals of the sale. `vals` will be updated with partner_invoice_id, pricelist_id, etc... | ||
|
|
||
|
|
There was a problem hiding this comment.
@sebastienbeau IMO we should explain why this way to trigger the onchanges is safe and generic....
"Behind the scene, play_onchanges will execute all the methods registered for the list of changed fields. To avoid performance issue when the method is called on a record , the record will be transformed into a memory record before calling the registered methods to avoid to trigger SQL updates command when values are assigned to the record by the onchange"
lmignon
approved these changes
Jun 12, 2018
EBII
added a commit
to EBII/server-tools
that referenced
this pull request
Dec 11, 2018
sbejaoui
pushed a commit
to acsone/server-tools
that referenced
this pull request
Dec 17, 2018
Laurent-Corron
pushed a commit
to acsone/server-tools
that referenced
this pull request
Oct 18, 2019
lmignon
pushed a commit
to acsone/server-tools
that referenced
this pull request
Nov 8, 2019
kevinkhao
pushed a commit
to akretion/server-tools
that referenced
this pull request
Nov 23, 2020
koenloodts
pushed a commit
to koenloodts/server-tools
that referenced
this pull request
Dec 14, 2021
AurelijaNorvaisaite
pushed a commit
to focusate/oca-server-tools
that referenced
this pull request
May 6, 2022
kevinkhao
pushed a commit
to akretion/server-tools
that referenced
this pull request
Nov 30, 2022
BT-atornero
pushed a commit
to BT-atornero/server-tools
that referenced
this pull request
Jan 18, 2023
john-herholz-dt
pushed a commit
to DeineTuer-GmbH/OCA_server-tools
that referenced
this pull request
Jan 11, 2024
PieterPaulussen
pushed a commit
to The-O-Team/server-tools
that referenced
this pull request
Jul 18, 2024
thienvh332
pushed a commit
to thienvh332/server-tools
that referenced
this pull request
Sep 26, 2024
thienvh332
pushed a commit
to thienvh332/server-tools
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make play onchange working on existing record, see documentation.